Upgrade ethers to 5.4.6 / set-protocol-v2@0.1.0 #76
Conversation
This is incredibly generous. In full transparency, I contributed a very small amount to SetProtocol/set-protocol-v2#131 but I really appreciate all your hard work to untangle this web of upgrades @cgewecke! |
cgewecke
force-pushed
the
chris/update-ethers
branch
from
d8cc4b7
to
c0c190e
Compare
| ): Promise< | ||
| [BigNumber, BigNumber, BigNumber] & { | ||
| totalQuantity: BigNumber; | ||
| managerFee: BigNumber; | ||
| protocolFee: BigNumber; | ||
| } | ||
| > { |
There was a problem hiding this comment.
nice tuple type! Since this is public API, I'm sure consumers will appreciate this more precise type definition
Minor but the last release I see on GH is 0.1.0: https://github.com/SetProtocol/set.js/releases So out of curiosity, was the 0.2.x release line blacklisted? Or is 0.2.6 safe to consume and it just wasn't published to the GH releases page? |
cgewecke
changed the title
|
@rootulp The missing release for 0.2.x is an oversight. That version added some trade quote utilities that are used in TokenSets but didn't change anything else about the API here.... Will add a release for that with some usage notes... |
Pulls in changes at set-protocol-v2 PR 131 which upgrades ethers to 5.4.6 and uses a new typechain package
Upgrades
TODO
Note: There are a handful of breaking TS interface changes here (coming from upstream at set-protocol-v2). When we publish we should bump the version to 0.3.0