Skip to content

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Aug 29, 2021

Description

  • Upgrade dependencies so that set-protocol-v2 is usable by index-ui
  • Fixes Error resolving ethers/lib/utils set-protocol-v2#129
  • Fixes
    ../set.js/node_modules/ethers/lib.esm/ethers.js 20:0-22:20 Attempted import error: 'BaseContract' is not exported from '@ethersproject/contracts'.
    

Testing

  • I observed no more dependency errors when running
    cd set.js && yarn link
    cd ../index-ui && yarn link "set.js"
    yarn start
    

Description
- Upgrade dependencies so that set-protocol-v2 is usable by index-ui
- Fixes SetProtocol/set-protocol-v2#129
- Fixes
  ```error
  ../set.js/node_modules/ethers/lib.esm/ethers.js 20:0-22:20 Attempted import error: 'BaseContract' is not exported from '@ethersproject/contracts'.
  ```

Testing
- I observed no more dependency errors when running
  ```
  cd set.js && yarn link
  cd ../index-ui && yarn link "set.js"
  yarn start
  ```
@cgewecke cgewecke changed the base branch from master to chris/review_71 August 30, 2021 16:08
@cgewecke
Copy link
Contributor

@rootulp Thanks for this!

(Am merging into a staging branch for review so CI runs. CircleCI was not configured to run on PRs forks when you opened here.)

@cgewecke cgewecke merged commit 261b920 into SetProtocol:chris/review_71 Aug 30, 2021
@rootulp rootulp deleted the rp/upgrade-set-protocol-v2 branch August 31, 2021 02:08
@rootulp rootulp restored the rp/upgrade-set-protocol-v2 branch August 31, 2021 02:38
@rootulp
Copy link
Contributor Author

rootulp commented Aug 31, 2021

This didn't work on CI: https://app.circleci.com/pipelines/github/SetProtocol/set.js/395/workflows/8a5e4557-d59c-472b-a21e-eca2541d1334/jobs/714

I can open a new PR after I investigate and fix

@rootulp rootulp deleted the rp/upgrade-set-protocol-v2 branch August 31, 2021 02:41
@cgewecke
Copy link
Contributor

@rootulp

I'm going to try to untangle this at set-protocol-v2 today. As you noted in your issue there, we have several versions of ethers and the types & import situation is really complicated there

  • ethers has many breaking types changes between various v5 version
  • the ethers version we pick should support (or be type-compatible) with whatever ethers supports EIP 1559 (for our deployments)
  • there are lots of @ethersproject/<package> imports in the code and they need to match the "main" ethers version.
  • ethers should work with typechain/hardhat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error resolving ethers/lib/utils
2 participants