-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use loadLegacyFabricCss in SPFX 1.8 #3612
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Thank you to @srideshpande for finding a temporary solution. The final one will require an update to our public packages. Go to the below location
Add the following line to the file before the 'canUpdateConfiguration' entry
save, and run gulp or gulp build or gulp bundle or gulp --ship. |
@patmill Is this fixed yet? I am facing the same issue when I used it yesterday. @araLT Can you reopen the bug as it is not fixed yet and the temporary solution would not work in build pipelines? For now, I am just including the fabric css file directly using |
@patmill is this fixed yet? I am also facing same issue but with another property 'supportedHosts:["SharePointWebPart","TeamsTab"]' When I am passing this values in manifiest file of project I am getting error. |
Fixed with the v1.8.1 release - see release notes at - https://github.com/SharePoint/sp-dev-docs/wiki/SharePoint-Framework-v1.8.1-release-notes |
Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues |
Category
Expected or Desired Behavior
According to SPFX 1.8 documentation, it is possible to add "loadLegacyFabricCss": true to web part manifest file in order to force old fabric CSS to be loaded in the page.
Observed Behavior
After adding the mentioned property (
"loadLegacyFabricCss": true
) to web part manifest file, execution of commandsgulp serve
orgulp bundle
failed and after webpacking the following error message is displayed:[15:29:01] Error - [write-manifests] Manifest validation error (./src/webparts/helloWorld/HelloWorldWebPart.manifest.json):
(#/) Data does not match any schemas from 'oneOf'
(#/) Missing required property: description
(#/) Missing required property: extensionType
(#/componentType) No enum match for: WebPart
(#/) Additional properties not allowed: loadLegacyFabricCss
(#/) Missing required property: items
(#/) Missing required property: rootComponentId
Steps to Reproduce
Create new spfx 1.8 project containing web part.
Add
"loadLegacyFabricCss": true
to web part manifest file. Here is Example of such manifest file:Run command
gulp serve
orgulp bundle
and you will get the mentioned error:The text was updated successfully, but these errors were encountered: