Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turning all jobs as async and async/await improvements #558

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Turning all jobs as async and async/await improvements #558

merged 4 commits into from
Jun 8, 2024

Conversation

henriqueholtz
Copy link
Member

The changes are made based on .NET AsyncGuidance.

  • Turning all jobs as async
  • Got rid some warnings
  • Getting rid .Result
  • Adding some TODO comments for next improvements

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@AppVeyorBot
Copy link

✅ Build Sharebook-Backend: PR Check 1.0.93-fcftyrxi completed (commit e1f07b9470 by @henriqueholtz)

@raffacabofrio raffacabofrio merged commit 50b6a4d into SharebookBR:develop Jun 8, 2024
5 of 6 checks passed
@henriqueholtz henriqueholtz mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raffacabofrio raffacabofrio raffacabofrio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henriqueholtz @AppVeyorBot @raffacabofrio