Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnitTests forcing SDK NuGet package to be broken #185

Merged

Conversation

andrew-boyarshin
Copy link
Contributor

@andrew-boyarshin andrew-boyarshin commented Mar 3, 2021

UnitTests depended on SDK package, but MSBuildSdkExtras handles RID-specific output directories correctly for Pack, not for ProjectReference inner-Build. This caused erroneous output directories and extra files in the wrong places. .NET Core MSBuild tools folder was unnecessarily large.

@andrew-boyarshin andrew-boyarshin self-assigned this Mar 3, 2021
@andrew-boyarshin andrew-boyarshin marked this pull request as ready for review March 3, 2021 14:40
@andrew-boyarshin andrew-boyarshin requested a review from a team March 3, 2021 14:40
@andrew-boyarshin andrew-boyarshin merged commit 5b58644 into SharpGenTools:master Mar 3, 2021
@andrew-boyarshin andrew-boyarshin added this to the 2.0 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant