Skip to content

Conversation

omarpiani
Copy link
Member

I managed to update SharpRepository's StructureMap Ioc plugin to the brand new StructureMap 4.0 library. Code and performance is tested.

I currently testing successfully new library in my Asp.NET MVC 5 applications.

SharpRepository.Ioc.StructureMap project

  • Uses StructureMap4
  • Supports new RepositoryFactory methods for ICompoundKeyRepository<T, TKey, TKey2, TKey3> and ICompoundKeyRepository added in last commit
  • StructureMapDependencyResolver to StructureMapRepositoryDependencyResolver because that name is too common and doesn't respect BaseRepositoryDependencyResolver abstract

SharpRepository.Tests.Integration project

  • Existing test working
  • New tests for the new ICompoundKeyRepository<T, TKey, TKey2, TKey3> and ICompoundKeyRepository

SharpRepository.Benchmarks.Configuration project

  • Updated succesfuly
  • Test running with same performance

- IoC StructureMap package not working
Test successfully working
…encyResolution class renamed to StructureMapRepositoryDependencyResolution
@jtreuting
Copy link
Member

This is great. Having this updated is really nice and I appreciate the work to make it happen. I will try to review this in the next week or so. If I haven't gotten it done in a week please add a comment here telling me to make it happen (as a friendly reminder of course).

@omarpiani
Copy link
Member Author

8 days are passed my friend!

@omarpiani
Copy link
Member Author

15 days 👍

@jtreuting
Copy link
Member

I am scheduling time tonight to review and approve this one and then hopefully over the weekend I will be able to look at some of the other outstanding items.

Thanks for staying on me about it, I do actually appreciate it :)


From: fiorebat notifications@github.com
Sent: Friday, February 12, 2016 1:38 AM
To: SharpRepository/SharpRepository
Cc: Jeff Treuting
Subject: Re: [SharpRepository] Upgraded to StructureMap 4.0 (#145)

15 days

Reply to this email directly or view it on GitHubhttps://github.com//pull/145#issuecomment-183252767.

jtreuting added a commit that referenced this pull request Feb 15, 2016
Upgraded to StructureMap 4.0
@jtreuting jtreuting merged commit f3542c5 into SharpRepository:master Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants