Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint.txt file in Alignment directories is not parsed correctly #96

Closed
ressy opened this issue Aug 27, 2020 · 0 comments · Fixed by #97
Closed

Checkpoint.txt file in Alignment directories is not parsed correctly #96

ressy opened this issue Aug 27, 2020 · 0 comments · Fixed by #97
Labels
bug Something isn't working
Milestone

Comments

@ressy
Copy link
Member

ressy commented Aug 27, 2020

Related to #91, illumina.util.load_checkpoint only works as expected with the most common case, for a completed FASTQGeneration. Looking at Checkpoint.txt for interrupted/failed cases I see that in general there's both an integer and a keyword (which just happens to be an empty string in the common case). load_checkpoint should be updated to parse out both an integer and a keyword in all cases.

@ressy ressy added the bug Something isn't working label Aug 27, 2020
@ressy ressy added this to the Version 0.0.4 milestone Aug 27, 2020
ressy added a commit that referenced this issue Aug 27, 2020
The example files here cover all three cases I've observed in
Checkpoint.txt files, two of which would not parse correctly with the
existing load_checkpoint code.  These tests assume we get back a
2-member list with an integer and a keyword in all three cases.
ressy added a commit that referenced this issue Aug 27, 2020
Switch from a single integer to a list containing an integer+keyword
pair
@ressy ressy closed this as completed in #97 Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant