Liking is sharing #208
Liking is sharing #208
Conversation
…ng a frame as an option
ghost
assigned 
|
please grab me after lunch @Sztul, i'll join you guys to understand and danSpinosa.com On Tue, Nov 26, 2013 at 10:59 AM, Henry Sztul notifications@github.comwrote:
|
| @@ -10,7 +10,7 @@ end | |||
|
|
|||
| if @include_frame_children | |||
|
|
|||
| attributes :id, :score, :upvoters, :view_count, :frame_ancestors, :frame_children, :creator_id, :conversation_id, :roll_id, :video_id, :like_count | |||
| attributes :id, :score, :upvoters, :view_count, :frame_ancestors, :frame_children, :creator_id, :conversation_id, :roll_id, :video_id, :like_count, :type | |||
There was a problem hiding this comment.
Need to find other places where the API is returning frames to the client and add in the :type attribute (definitely C code, but sometimes also you'll find funny rabl templates that don't re-use the canonical one for the object in question)
| Settings::Channels['community_channel_user_id'] = @community_channel_user.id.to_s | ||
| @user = Factory.create(:user) | ||
| @roll = Factory.create(:roll, :roll_type => Roll::TYPES[:special_public_real_user], :creator => @user) | ||
| @frame = Factory.create(:frame, :roll => @roll, :creator => @user, :video => @video) |
There was a problem hiding this comment.
I can't see what we're using these new @ variables for, can you enlighten me @hsztul?
…ame type to heavy_weight
…o liking-is-sharing
This touches the Frame Model, GT::Framer, Frame Controller, and all associated tests.
@iceberg901 can go over in person to run through it all after lunch?