edge property hack: prereq for flatgraph -> odb converter #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrehm
approved these changes
Jul 11, 2024
In order to prepare for a potential rollback to overflowdb in the future, we're creating a flatgraph->overflowdb converter. Since flatgraph supports exactly one edge property only, there are no edge property names. So when we deserialise and find exactly one edge property with the name `EDGE_PROPERTY`, and the schema defines exactly one edge property, then we assume that's the one. Let's be clear: this is a dirty hack, but since we're phasing out overflowdb in favor of flatgraph, it's arguably ok.
mpollmeier
force-pushed
the
michael/flatgraph-backport-edge-property-reading
branch
from
0ed8b64 to
befafef
Compare
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prepare for a potential rollback to overflowdb in the future, we're creating a
flatgraph->overflowdb converter. Since flatgraph supports exactly one edge property only,
there are no edge property names. So when we deserialise and find exactly one edge property with
the name
EDGE_PROPERTY, and the schema defines exactly one edge property, then we assume that's the one.Let's be clear: this is a dirty hack, but since we're phasing out overflowdb in favor of flatgraph, it's
arguably ok.