Skip to content

move from pio to idf toolchain #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 29, 2020
Merged

move from pio to idf toolchain #50

merged 9 commits into from
Mar 29, 2020

Conversation

nopeslide
Copy link
Contributor

@nopeslide nopeslide commented Mar 22, 2020 •
edited
Loading

regarding #49

  • add idf docker image
  • add idf docker container
  • rebase other docker images on idf
    • tested qemu container
    • tested vscode container
    • remove pio docker images/container
  • restructure repo
  • modify main Makefile to use idf docker
    • tested build
    • tested monitor
    • tested flash
    • tested clean
    • tested distclean
    • add menuconfig target
  • binary works
    • compiles
    • ulp works
    • binary does not crash
  • documentation

@nopeslide nopeslide added docker idf espressif toolchain infrastructure Toolchain related make Makefiles pio platformio labels Mar 22, 2020
@nopeslide nopeslide changed the title docker:feature added idf image/container generation move from pio to idf toolchain Mar 26, 2020
@nopeslide nopeslide marked this pull request as ready for review March 26, 2020 08:37
@nopeslide nopeslide force-pushed the idf branch 5 times, most recently from e4f04db to 7bb2045 Compare March 26, 2020 17:35
nopeslide
nopeslide commented Mar 26, 2020
View reviewed changes
Copy link
Contributor Author

@nopeslide nopeslide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reviewable.
a little bit more documentation needs to be added

@nopeslide nopeslide mentioned this pull request Mar 27, 2020
Merged
5 tasks
jhonnyam
jhonnyam reviewed Mar 28, 2020
View reviewed changes
Copy link
Contributor

@jhonnyam jhonnyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jhonnyam
jhonnyam requested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@jhonnyam jhonnyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jhonnyam jhonnyam merged commit c7f4d23 into ShilaTu:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonnyam jhonnyam jhonnyam approved these changes

@ikstream ikstream Awaiting requested review from ikstream

@reporiot reporiot Awaiting requested review from reporiot

Assignees
No one assigned
Labels
docker idf espressif toolchain infrastructure Toolchain related make Makefiles pio platformio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopeslide @jhonnyam