Skip to content

Conversation

reporiot
Copy link
Contributor

@reporiot reporiot commented Apr 2, 2020

Related Issues & PRs

Description

  • Implement task macro.
  • Implement queue macro.
  • Adjust current code to use the macros.

Context

From #58 : The declaration and definition of a modules data structures should be made easier through the use of macros. Structures, relying on FreeRTOS, often require extensive use of many types like tasks and queues which in turn depend on stacks and buffers.

Testing

none

Documentation

none

@reporiot reporiot force-pushed the feat_task_macro branch 4 times, most recently from 7216f35 to c676a79 Compare April 5, 2020 18:35
@reporiot reporiot changed the title macros:feature component setup macros:feature task and queue interfaces Apr 5, 2020
@reporiot reporiot marked this pull request as ready for review April 5, 2020 19:49
@reporiot reporiot requested review from ikstream and nopeslide April 5, 2020 19:50
@reporiot reporiot requested a review from nopeslide April 8, 2020 21:07
@reporiot reporiot dismissed nopeslide’s stale review April 8, 2020 21:48

Most suggestions applied, please rereview

Copy link
Contributor

@nopeslide nopeslide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would pass a reference to the whole unit to each entry point of the tasks,
since it should contain all configurable options

@nopeslide
Copy link
Contributor

how about we rename the lifesensor_macro component to lifesensor or lifesensor_common to accommodate non macro additions and introduce a macro folder inside the include dir so imports refer to macro/queue.h and so on

@reporiot
Copy link
Contributor Author

reporiot commented Apr 9, 2020

Applied as requested

how about we rename the lifesensor_macro component to lifesensor or lifesensor_common to accommodate non macro additions and introduce a macro folder inside the include dir so imports refer to macro/queue.h and so on

@reporiot reporiot requested a review from nopeslide April 9, 2020 11:54
@reporiot reporiot requested a review from nopeslide April 9, 2020 16:14
@nopeslide nopeslide merged commit 3de9d36 into ShilaTu:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants