Skip to content

Conversation

jhonnyam
Copy link
Contributor

@jhonnyam jhonnyam commented May 12, 2020

Related Issues & PRs

Description

  • Fix too short timeout in channel_queue test by setting timeout to number of running tasks

Context

Assuming, the test fails because there are more then one task runnable with same or higher Priority.
Setting the timeout to the number of running tasks should ensure, that all tasks get scheduled before timeout get's hit.

@jhonnyam jhonnyam assigned jhonnyam and nopeslide and unassigned jhonnyam May 12, 2020
@jhonnyam jhonnyam changed the title esp32:fix Changed timout for channel_broadcast test esp32:fix Changed timout for channel_queue test May 12, 2020
@nopeslide nopeslide mentioned this pull request May 12, 2020
9 tasks
Copy link
Contributor

@nopeslide nopeslide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nopeslide nopeslide merged commit 245f978 into ShilaTu:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants