-
Notifications
You must be signed in to change notification settings - Fork 8
Updates for the elixir version of SimEngine #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and point the tests to the new SimEngine API URL [skip ci]
… 'M6 K 3 C3' -> 'M6K 3C3'
KaseyCantu
commented
Jul 2, 2021
@KaseyCantu The tracking URL tests have been updates and are passing. The only thing left is making it so string variables are also handled as a null type, I figured you would be able to knock that out quicker than me, but let me know if I can help at all on that front! |
…warnings come up on the tests
Observer pattern event implementation
Observer pattern event tests using spies
…ember and value from Endpoints enum
Event tests using spies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA covered:
DX-1689 - Port shipengine-python to Elixir simengine implementation.
DX-1701 - Related updates on Elixir SimEngine side
Using the SimEngine endpoint: https://shipengine-web-api.herokuapp.com
Update ID/URL/UTC to Id/Url/Utc
Update ids to be base58
Etc/get address/track package tests passing
Note inconsistencies/unexpected values on the Elixir API service that would need to be updated
(UPDATE: Ensure no trackingUrl assertions are commented out). Determine if when we would expect
tracking_result.package.tracking_url
to not be null (un-comment and resolve in test or elixir result). Intests/services/test_track_package.py
the teststest_track_by_tracking_number_and_carrier_code
andtest_track_by_package_id
theassert tracking_result.package.tracking_url is not None
type assertions are commented outUpdate models to handle null values for string fields, and ensure no warnings come up on the tests for
RuntimeWarning:
NoneTypeobject value of non-optional type phone detected
etc. for the name/phone/company address fields