Skip to content

Dx 1042 to 1050 normalize address tests #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 8, 2021
Merged

Dx 1042 to 1050 normalize address tests #7

merged 21 commits into from
Jun 8, 2021

Conversation

KaseyCantu
Copy link
Contributor

JIRA's covers:

  • DX-1042 - test validate commercial address
  • DX-1043 - test validate address of unknown type
  • DX-1044 - test multi-line address
  • DX-1045 - test numeric postal code
  • DX-1046 - test alpha postal code
  • DX-1047 - test non-latin characters
  • DX-1048 - test with warnings
  • DX-1049 - test with 1 error message
  • DX-1050 - test with multiple error messages

KaseyCantu added 21 commits June 4, 2021 15:45
@KaseyCantu
Acceptance criteria per DX-1039 - Normalize Address Implementation - h…
610418e 
…ttps://auctane.atlassian.net/browse/DX-1039
@KaseyCantu
fixed imports
95dbe9d
@KaseyCantu
Added generic error to ErrorType enumeration.
184f998
@KaseyCantu
work in progress
da3b47e
@KaseyCantu
Acceptance criteria per DX-1041 - Normalize valid residential address.
908419e
@KaseyCantu
Moved assertion functions for re-use throughout the test suite.
d112a60
@KaseyCantu
Imported normalize method an created normalize_address()
69c50cc
@KaseyCantu
formatting fix
3648145
@KaseyCantu
Acceptance criteria per DX-1042 - Normalize valid commercial address. h…
902308e 
…ttps://auctane.atlassian.net/browse/DX-1042
@KaseyCantu
Work in progress - optimizing tests.
2ce3720
@KaseyCantu
work in progress - test optimizations.
8b5cb77
@KaseyCantu
Acceptance criteria per DX-1043 - Normalize unknown address. https://…
b930f29 
…auctane.atlassian.net/browse/DX-1043
@KaseyCantu
DX-1044 - Normalize multi-line address. https://auctane.atlassian.net…
5a0acde 
…/browse/DX-1044
@KaseyCantu
DX-1045 - Normalize address with numeric postal code. https://auctane…
995a22f 
….atlassian.net/browse/DX-1045
@KaseyCantu
DX-1046 - Normalize address with alpha-numeric postal code. https://a…
3e05821 
…uctane.atlassian.net/browse/DX-1046
@KaseyCantu
DX-1047 - Normalize address with non-latin characters. https://auctan…
d6fafbf 
…e.atlassian.net/browse/DX-1047
@KaseyCantu
DX-1048 - Normalize address with warnings. https://auctane.atlassian.…
9a89cff 
…net/browse/DX-1048
@KaseyCantu
work in progress - test optimizations
e1a8d7f
@KaseyCantu
DX-1049 - Normalize address with single error message. https://auctan…
2a163f7 
…e.atlassian.net/browse/DX-1049
@KaseyCantu
DX-1050 - Normalize address with multiple error messages. https://auc…
c7d4041 
…tane.atlassian.net/browse/DX-1050
@KaseyCantu
Housekeeping
cb4056e
@KaseyCantu KaseyCantu requested a review from pierce-h June 8, 2021 17:09
pierce-h
pierce-h reviewed Jun 8, 2021
View reviewed changes
pierce-h
pierce-h approved these changes Jun 8, 2021
View reviewed changes
Copy link

@pierce-h pierce-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaseyCantu left you one comment. Great PR!

@KaseyCantu KaseyCantu merged commit 3d00e8a into main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pierce-h pierce-h pierce-h approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KaseyCantu @pierce-h