-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: assets/theme.css.liquid
and assets/theme.js.liquid
files not hot reloading
#2614
Comments
@Shopify/theme-code-tools could you please have a look? |
Probably related to #2613 |
Hey Guys, we noticed this issue since last week and we investigated it further. here are what we have found, which could help to debug this issue further. FindingsAsset file (ex. theme.css.liquid)
What we did and didn't work
WorkaroundIt turnout to be if the file has .liquid extension it won't work!! but if you only use .css it will work just fine. so if you don't use liquid in that file, then as a workaround try using normal css extension not liquid. OR use the customizer for now to check your changes. Hope this helps, till the root issue got fixed. |
Having the same issue since Friday. I found that if I save the swatches.css.liquid file with a change (I add a period after the closing bracket and save, and then when I make my next change to preview in the browser I delete it and save) it updates to the most recent styles. Not ideal, but allows me to still work locally. |
I have the same issue except mine is with a .js.liquid file. It was working fine when it was just .js file but after switching to .js.liquid the changes are not reflecting, although they will appear to correct at some later time 10 minutes or an hour later. |
+1 Here. |
+1 |
+1 - just started happening this week for me. |
+1 I just noticed this issue yesterday. For context, I'm using a vintage theme (OS 1.0) with themekit, but it's the same Things that haven't caused the /assets/*.liquid file to update on the frontend:
Things that have caused the /assets/*.liquid file to update on the frontend:
I hope this helps. |
👋 Hello everyone, Yesterday, we applied a platform-level solution for this issue. As a result, it should now be resolved without any need for updates on your local tooling. Please, let me know if you're still facing this problem, so we can promptly reopen the issue. |
I'm not sure if this is related to the bug reports in this thread, but I'm facing a similar issue with the theme. I've opened an issue here: #2697 |
We still experience the issue on multiple projects. |
More ocurrences: #2613 (comment) |
I am having the same issue now. |
SAME! i thought i was going crazy. |
Hello, I am not sure how related this is, but in the context of theme app extension file syncing, es6-imported files (located within the same assets/ folder as other app extension files) are not consistently updated either, especially when running the "shopify dev" command, despite the CLI acknowledging the update and claiming such files were indeed "pushed to a draft". The deploy command doesn't seem to have as much of an issue with this but I would think the expected behavior would be that such files would update regardless of the command used. |
We are currently experiencing a persistent issue where the .liquid files located in the assets folder are not being updated as expected. This is particularly concerning since our workflow relies on injecting general liquid variables for various design elements such as colors. Despite receiving confirmation from the Command Line Interface (CLI) indicating that the file has been updated, a manual inspection reveals that the CSS changes are not reflected in the file. This is confirmed by simply removing .liquid and everything starts to work well everything that does not have a liquid variable. Something is wrong with the parser on Shopify side. Additionally, we are facing significant challenges with the Hot Reload feature. Upon modifying a single file, our custom Vite configuration processes the SCSS and Tailwind classes, directing the output to the assets folder. Although the CLI acknowledges the update and uploads the single modified file, it triggers an excessive number of refreshes—approximately a dozen for a single file update. This behavior is highly irregular and disrupts our development process. We are absolutely sure we are not syncing multiple files and it only happens with CSS and JS files. For some reason liquid files are ok. But even if we were uploading multiple files Hot Reload should wait for all the files to be uploaded before firing. It is crucial that we address these issues promptly to maintain efficiency and ensure the integrity of our project's development workflow. |
This is happening to me now as well and seems completely random. CLI is up to date Files are listed as |
Also happens when editing directly in the Edit Code area of the Shopify admin. |
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
We're still experiencing this issue. The activity is low because the community has seen no motivation to resolve this issue. This is your personal brand's fault, not the community. |
👋🏻 Hi all, this issue is on our radar and is being prioritized. As mentioned in this comment, using the third preview link is a workaround to ensure changes are previewed correctly. Thanks for your patience 🙏🏻 |
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
Hi there, Any progress on this issue? |
assets/theme.css.liquid
and assets/theme.js.liquid
files not hot reloading
I am also seeing a similar issue, I added a css and js file to assets that i'm working on, and made them load in the theme.liquid file, however every few refreshes or so the preview will load an empty file instead (I checked in the sources tab of inspector), requiring me to stop the theme dev and then restart it. This is a very frustrating experience, would really like it to be fixed |
Hey everybody! Could you please try on I want to validate that I'm trying all the correct steps for reproduction, as I've tried a couple of different versions and my efforts have not been fruitful. If you are still experiencing this issue, please fill out the Issue template provided below and attach it as a comment in this thread. Thanks! cc: @mvlad-reb @Tigatok @jmsquatch @francisfernandez Issue TemplateReproduction stepsVerbose output (Execute command with the
|
Definitely still happening, but it seems to be specifically with some CSS files that weren't part of the original theme I'm working on. Not sure if that's a relevant fact. |
@mvlad-reb That helps! Thanks for the info :) |
I am still getting this issue with the latest Shopify CLI package (3.79.0) with CSS files being loaded empty while in theme dev mode. |
@mvlad-reb Hi 👋 Our test process was:
Modifying If this is not what you are experiencing, can you provide some steps to reproduce it? Or can you record a quick video to show it? |
This is a CSS file I've added to the assets folder and then referenced it in the theme.liquid file in the |
@mvlad-reb I think there was a problem when you submited your previous message, it doesn't contain links or CSS content even when I check the source. Edit: Oh, maybe I misunderstood and you actually didn't add a CSS file to your message, just mentioning about a local file you have and are referencing it in the |
Yes that's correct, sorry, I meant that as in "this is happening with a CSS file", yes. |
We haven't been able to reproduce this, so we may need some more information Can you please open a bug report with verbose logs? You can tag me in that issue. Thanks! |
Please confirm that you have:
In which of these areas are you experiencing a problem?
Theme
Expected behavior
Changes done in the theme.css.liquid should sync and reflect in the front end.
Actual behavior
Any changes in the theme.css.liquid are not synced. Shopiy CLI shows an update has been made for assets/theme.css.liquid, but they do not show up in the front end.
Changes can be seen in the file when looking directly at the admin file.
My current workaround is to create a new .css file (without the .liquid format) to apply styling.
Reproduction steps
Operating System
Mac OS Monterey 12.6.3
Shopify CLI version (check your project's
package.json
if you're not sure)3.48.1
Shell
zsh
Node version (run
node -v
if you're not sure)20.5.0
What language and version are you using in your application?
Liquid, CSS
The text was updated successfully, but these errors were encountered: