-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extension devUUID to match remote extension UUID if exists #2895
Fix extension devUUID to match remote extension UUID if exists #2895
Conversation
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
99df81c
to
e65b883
Compare
Coverage report
Test suite run success1433 tests passing in 670 suites. Report generated by 🧪jest coverage report action from 4ea04a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 'ed, LGTM!
e65b883
to
4ea04a0
Compare
@Arkham this fix is addressing all the scenarios related to the dev flow, replacing the random dev UUID by the remote UUID right after the matching between local and remote extension happens. There where some changes introduced here which were relying on the .env file values generated after the first |
WHY are these changes introduced?
Fixes #461
UI extensions, in order to have live reload, communicate with Web by web sockets. The payload of the WS does not have the uuid updated to the one in the draft. As the UUID is used for reconciliation in EH dev plugin, this results in having two extensions rendered, the one stored in the DB as a draft and the one specified by the WS payload.
WHAT is this pull request doing?
The CLI already resolves the matching extensions, but this matching process was not updating the extension instance. To solve this:
How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.