-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Fix extension devUUID to match remote extension UUID if exists #2902
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.49.1";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.49.4";
\ No newline at end of file
packages/cli-kit/dist/public/node/error-handler.d.ts@@ -14,11 +14,9 @@ export declare function errorHandler(error: Error & {
export declare function sendErrorToBugsnag(error: unknown): Promise<{
reported: false;
error: unknown;
- unhandled: unknown;
} | {
error: Error;
reported: true;
- unhandled: boolean;
}>;
/**
* If the given file path is within a node_modules folder, remove prefix up
packages/cli-kit/dist/public/node/error.d.ts@@ -74,7 +74,7 @@ export declare function handler(error: unknown): Promise<unknown>;
*/
export declare function errorMapper(error: unknown): Promise<unknown>;
/**
- * A function that checks if an error should be reported as unhandled.
+ * A function that checks if an error should be reported.
*
* @param error - Error to be checked.
* @returns A boolean indicating if the error should be reported.
packages/cli-kit/dist/public/node/ui.d.ts@@ -30,7 +30,7 @@ export interface RenderConcurrentOptions extends PartialBy<ConcurrentOutputProps
* 00:00:00 │ frontend │ third frontend message
*
*/
-export declare function renderConcurrent({ renderOptions, ...props }: RenderConcurrentOptions): Promise<void>;
+export declare function renderConcurrent({ renderOptions, ...props }: RenderConcurrentOptions): Promise<void | void[]>;
export type AlertCustomSection = CustomSection;
export type RenderAlertOptions = Omit<AlertOptions, 'type'>;
/**
packages/cli-kit/dist/private/node/testing/ui.d.ts@@ -10,16 +10,14 @@ declare class Stderr extends EventEmitter {
}
export declare class Stdin extends EventEmitter {
isTTY: boolean;
- data: string | null;
constructor(options?: {
isTTY?: boolean;
});
write: (data: string) => void;
setEncoding(): void;
setRawMode(): void;
- ref(): void;
- unref(): void;
- read: () => string | null;
+ resume(): void;
+ pause(): void;
}
interface Instance {
rerender: (tree: ReactElement) => void;
packages/cli-kit/dist/public/node/testing/ui.d.ts@@ -1 +1 @@
-export { getLastFrameAfterUnmount, render, Stdin, waitForInputsToBeReady, waitForContent, sendInputAndWait, sendInputAndWaitForChange, sendInputAndWaitForContent, } from '../../../private/node/testing/ui.js';
\ No newline at end of file
+export { getLastFrameAfterUnmount, render, Stdin, waitForInputsToBeReady, waitForContent, } from '../../../private/node/testing/ui.js';
\ No newline at end of file
|
Coverage report
Test suite run success1431 tests passing in 669 suites. Report generated by 🧪jest coverage report action from f18f402 |
Cherry picking commits from #2895