Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned app config #3160

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Versioned app config #3160

merged 1 commit into from
Dec 21, 2023

Conversation

alvaro-shopify
Copy link
Contributor

@alvaro-shopify alvaro-shopify commented Dec 3, 2023

WHY are these changes introduced?

Fixes: https://github.com/Shopify/develop-app-foundations/issues/841

Move all the changes made in the prototype to a new branch that should be ready to be merged to main.

Cannot be merged before these PRs:

WHAT is this pull request doing?

Tasks

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 73.09% 6257/8561
🟡 Branches 70.73% 3045/4305
🟡 Functions 71.75% 1585/2209
🟡 Lines 74.23% 5942/8005

Test suite run success

1494 tests passing in 670 suites.

Report generated by 🧪jest coverage report action from 0896e62

@alvaro-shopify alvaro-shopify mentioned this pull request Dec 12, 2023
6 tasks
@github-merge-queue github-merge-queue bot merged commit 0896e62 into main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant