-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy fetch remote specs #3180
Conversation
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1513 tests passing in 696 suites. Report generated by 🧪jest coverage report action from 8cf1988 |
3c2a7de
to
79d3de5
Compare
23ca82a
to
167838e
Compare
0d1451c
to
a233750
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/object.d.ts@@ -45,4 +45,21 @@ export declare function deepCompare(one: object, two: object): boolean;
* @param two - The second object to be compared.
* @returns Two objects containing the fields that are different, each one with the values of one object.
*/
-export declare function deepDifference(one: object, two: object): [object, object];
\ No newline at end of file
+export declare function deepDifference(one: object, two: object): [object, object];
+/**
+ * Gets the value at path of object. If the resolved value is undefined, the defaultValue is returned in its place.
+ *
+ * @param object - The object to query.
+ * @param path - The path of the property to get.
+ * @returns - Returns the resolved value.
+ */
+export declare function getPathValue<T = object>(object: object, path: string): T | undefined;
+/**
+ * Sets the value at path of object. If a portion of path doesn't exist, it's create.
+ *
+ * @param object - The object to modify.
+ * @param path - The path of the property to set.
+ * @param value - The value to set.
+ * @returns - Returns object.
+ */
+export declare function setPathValue(object: object, path: string, value?: unknown): object;
\ No newline at end of file
packages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.52.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.51.0";
\ No newline at end of file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and it works as expected 👌
packages/app/src/cli/services/generate/fetch-extension-specifications.ts
Outdated
Show resolved
Hide resolved
e431a1f
to
ce3f4f5
Compare
a4f5b44
to
ba041c2
Compare
ba041c2
to
8cf1988
Compare
WHY are these changes introduced?
Follow-up: #3170
Follow-up: #3214
WHAT is this pull request doing?
specifications
optional for theApp loader
. Set default value to an empty array so no extensions are loaded in this case.deploy
command loads the app again with the extensions once theremote app
is selected, thus, thegated
specs are applied and in case they are not allowed the extensions are not loadedapp access
config module added. Supports the new sectionaccess
direct_api_offline_access
true | false to enable Online access for Direct APIHow to test your changes?
Create a new
cli
app and run theapp config link
command to link it to a new remote app.With the org beta flag
App Access Module
disabledaccess
with whatever valuedeploy
commandlink
command. The addedaccess
section content will be removed as the app module wasn't uploaded in the previousdeploy
With the org beta flag
App Access Module
enabledaccess
with whatever valuedeploy
commandaccess
sectionlink
command. Theaccess
section content will be restored to the content it had before running thedeploy
command as it was uploaded with itMeasuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.