This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
Prevent running the scheduler twice. #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushmatrix
changed the title
pushmatrix
added a commit
that referenced
this pull request
May 30, 2014
Prevent running the scheduler twice.
|
Nice fix Daniel, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rufus scheduler was being started twice ever since the refactoring of breaking out dashing into several modules (Found in Dashing 1.3.3). The cause of it is because the bin requires
dashing, which in turn requiresdashing/appwhich will create a new instance of the scheduler. Then, once thin boots up and loads the config.ru, it requiresdashingagain, creating yet another instance of the scheduler.We could go ahead and only require
dashing/appinside the config.ru, but that would mess up previous people's config files.This is something to refactor in Dashing 2.0.