Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add shadowDOM support #348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Add shadowDOM support #348

wants to merge 1 commit into from

Conversation

owen-m1
Copy link
Contributor

@owen-m1 owen-m1 commented Jun 16, 2019

Todo:

  • Finish adding real target detection to other sensors
  • Replace all query selections with querySelectAll util to query inside shadowDOMs
  • Write tests

This branch been tested on... (click all that apply / add new items)

Browsers:

  • Chrome version
  • Firefox version
  • Safari version
  • IE / Edge version
  • iOS Browser version
  • Android Browser version

@owen-m1 owen-m1 self-assigned this Jun 16, 2019
@owen-m1 owen-m1 mentioned this pull request Jun 16, 2019
Closed
@owen-m1 owen-m1 force-pushed the shadowDOM-support branch from 31e95c9 to fd9e0ee Compare July 12, 2019 15:01
@FabianTerhorst
Copy link

Is it planned to add support for dynamically adding shadow roots as well? E.g. draggable.addDocument(...)

@owen-m1
Copy link
Contributor Author

owen-m1 commented Jul 14, 2019

@FabianTerhorst It is planned to work seamlessly with any ShadowDOM, you will not even have to specify them to Draggable.

@minicatsCB minicatsCB mentioned this pull request Oct 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@owen-m1 owen-m1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-m1 @FabianTerhorst