Update the return types of the Customer Account API query #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n methods. Also change the Customer Account API to default to 2024-01.
michenly
reviewed
Dec 4, 2023
michenly
reviewed
Dec 4, 2023
Comment on lines
+6
to
+8
| const {data} = await context.customer.query<{ | ||
| customer: {firstName: string; lastName: string}; | ||
| }>(`#graphql | ||
| }>(`#graphql:customer |
There was a problem hiding this comment.
👍💯 the previous example got me real confuse if customer is being use because of graphql field name or as a key word for named graphel end point
michenly
reviewed
Dec 4, 2023
Co-authored-by: Michelle Chen <michelle.chen@shopify.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We can't always assume there is a
dataproperty on the Customer Account API response. Also, the other properties,errorsandextensionsimportant and useful to the developer.WHAT is this pull request doing?
Return a complete response from the Customer Account API. Also change to 2024-01 as the default API version. Also, to prevent collisions on autocomplete/code gen with SFAPI, update the query comment to be
#graphql customerHOW to test your changes?
Does the example still work?
Post-merge steps
Checklist