🐛 edit customer api env variable name to sync with cli #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
michenly
force-pushed
the
mc-customer-api-env-var-fix
branch
2 times, most recently
from
307cf27
to
e5fdf11
Compare
michenly
force-pushed
the
mc-customer-api-env-var-fix
branch
from
e5fdf11
to
ff044e4
Compare
michenly
force-pushed
the
mc-customer-api-env-var-fix
branch
2 times, most recently
from
46efe1c
to
9ef4f92
Compare
michenly
commented
Dec 4, 2023
Comment on lines
+27
to
+28
| PUBLIC_CUSTOMER_ACCOUNT_API_CLIENT_ID: string; | ||
| PUBLIC_CUSTOMER_ACCOUNT_API_URL: string; |
There was a problem hiding this comment.
feels a bit funny that we are manually updating these.
@frandiox does CLI have a type defined when it create the .env file already that can be imported?
There was a problem hiding this comment.
Not at the moment. One thing I wanted to do was extracting these types in env.generated.d.ts or similar and generate the file automatically when .env changes but never got to do it.
There was a problem hiding this comment.
ok, future task then!
michenly
force-pushed
the
mc-customer-api-env-var-fix
branch
from
9ef4f92
to
416877c
Compare
This comment has been minimized.
This comment has been minimized.
michenly
force-pushed
the
mc-customer-api-env-var-fix
branch
from
416877c
to
1d92b56
Compare
frandiox
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
If user use
h2 link/env pullto create environment variables the customer-api example will break.WHAT is this pull request doing?
Update the two variables name in the example to sync up with the variable name cli create.
Also updated the ngrok comment so you never need to update
package.jsonagainHOW to test your changes?
Post-merge steps
Checklist