Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template rendering from the command line #228

Conversation

maxlaverse
Copy link
Contributor

Hey!
Would it be acceptable to have a feature to only render templates and not applying them ? Similar to what can be done with Helm ?

This allows parsing the generated template to extract some information for other tools, like all the images involved.

@maxlaverse maxlaverse force-pushed the add_support_for_template_rendering branch 2 times, most recently from b5d6784 to 022c4dc Compare December 19, 2017 19:35
@KnVerey
Copy link
Contributor

KnVerey commented Dec 19, 2017

Hi! I think this is a great idea, and it fits in nicely with some thoughts I was having about the future of rendering in this tool (#44 (comment)). Can you make it a completely separate command though? Maybe kubernetes-render? That would also require extracting a renderer class that could be called from both the new executable and DeployTask, which I think makes a lot of sense, especially as the renderer gets more complex. IMO the class extraction is also required for #207, so please coordinate with @skaes (who isn't at Shopify either--it's great to have all these contributions! ❤️ ) about who will have time to do that piece first.

@KnVerey KnVerey mentioned this pull request Dec 19, 2017
@maxlaverse
Copy link
Contributor Author

Sure @KnVerey , I'll talk to him

@maxlaverse maxlaverse force-pushed the add_support_for_template_rendering branch 2 times, most recently from 1c1603a to 1e0c89f Compare March 4, 2018 11:16
@maxlaverse maxlaverse force-pushed the add_support_for_template_rendering branch from 1e0c89f to 26887cc Compare March 4, 2018 11:38
@maxlaverse
Copy link
Contributor Author

Hi @KnVerey.
I rebased the PR and introduced a new command as suggest.
Could you point me in the direction you want this feature to go ?

@maxlaverse
Copy link
Contributor Author

maxlaverse commented Mar 8, 2018

I won't really have time to work on this pull-request anymore.
I prefer to close it and re-open it in the future if I want to invest in that direction again.

@maxlaverse maxlaverse closed this Mar 8, 2018
@maxlaverse maxlaverse deleted the add_support_for_template_rendering branch March 8, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants