828 fix content variable error #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM cc @dylanahsmith @fw42 |
fw42
reviewed
Feb 17, 2017
| @@ -235,4 +235,11 @@ def test_including_via_variable_value | |||
|
|
|||
| assert_template_result "Product: Draft 151cm ", "{% assign page = 'product' %}{% include page for foo %}", "foo" => { 'title' => 'Draft 151cm' } | |||
| end | |||
|
|
|||
| def test_including_with_strict_variables | |||
| template = Liquid::Template.parse("{% include 'simple' %}", error_mode: :warn) | |||
There was a problem hiding this comment.
Does this template ("simple") exist?
There was a problem hiding this comment.
No, it does not need to exists to show the issue under test. In fact, AFAIR I added the template but removed it again before comitting, since it was not needed here.
dylanahsmith
approved these changes
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #828
The test describes the wanted behaviour of not adding an error when including a template when using
strict_variables: true