Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OffenseCollection and Configuration public #289

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

alexevanczuk
Copy link
Contributor

@alexevanczuk alexevanczuk commented Dec 16, 2022

What are you trying to accomplish?

OffenseCollection should be public since it's part of the public API for OffensesFormatter and needs to be referenced in the sig when creating another implementation of the OffensesFormatter.

Configuration should be public since it's part of the public API for Validator.

What approach did you choose and why?

Making constants public by removing private_constant.

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

@alexevanczuk alexevanczuk requested a review from a team as a code owner December 16, 2022 17:16
@alexevanczuk alexevanczuk changed the title Make OffenseCollection public Make OffenseCollection and Configuration public Dec 16, 2022
@alexevanczuk alexevanczuk merged commit 7428f23 into main Dec 16, 2022
@alexevanczuk alexevanczuk deleted the ae-offense-collection branch December 16, 2022 20:06
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems March 1, 2023 19:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants