Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Commit b0edfbb

Browse files
authored
[Tabs] Restores the edit-columns icon, causing a breaking change (#11281)
### WHY are these changes introduced? Fixes a breaking change introduced on this [PR](#10800 (review)) where the `edit-columns` action type was removed. <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Restores the `edit-columns` action <img width="162" alt="Screenshot 2023-12-06 at 2 58 53 a m" src="https://github.com/Shopify/polaris/assets/5873627/2b1cb7cb-91c6-4700-92d6-c11615612b0f"> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent 32cfbec commit b0edfbb

File tree

26 files changed

+65
-2
lines changed

26 files changed

+65
-2
lines changed

.changeset/rare-rings-sing.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/polaris': patch
3+
---
4+
5+
Restores the Tab's `edit-columns` action type

polaris-react/locales/cs.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@
213213
"rename": "Přejmenovat zobrazení",
214214
"duplicate": "Duplikování zobrazení",
215215
"edit": "Upravit zobrazení",
216+
"editColumns": "Upravit sloupce",
216217
"delete": "Odstranit zobrazení",
217218
"copy": "{name} – kopie",
218219
"deleteModal": {

polaris-react/locales/da.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@
213213
"rename": "Omdøb visning",
214214
"duplicate": "Dupliker visning",
215215
"edit": "Rediger visning",
216+
"editColumns": "Rediger kolonner",
216217
"delete": "Slet visning",
217218
"copy": "Kopi af {name}",
218219
"deleteModal": {

polaris-react/locales/de.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@
213213
"rename": "Ansicht umbenennen",
214214
"duplicate": "Ansicht duplizieren",
215215
"edit": "Ansicht bearbeiten",
216+
"editColumns": "Spalten bearbeiten",
216217
"delete": "Ansicht löschen",
217218
"copy": "Kopie von {name}",
218219
"deleteModal": {

polaris-react/locales/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,7 @@
294294
"rename": "Rename view",
295295
"duplicate": "Duplicate view",
296296
"edit": "Edit view",
297+
"editColumns": "Edit columns",
297298
"delete": "Delete view",
298299
"copy": "Copy of {name}",
299300
"deleteModal": {

polaris-react/locales/es.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@
213213
"rename": "Cambiar nombre de vista",
214214
"duplicate": "Duplicar vista",
215215
"edit": "Editar vista",
216+
"editColumns": "Editar columnas",
216217
"delete": "Eliminar vista",
217218
"copy": "Copia de {name}",
218219
"deleteModal": {

polaris-react/locales/fi.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@
213213
"rename": "Nimeä näkymä uudelleen",
214214
"duplicate": "Kopioi näkymä",
215215
"edit": "Muokkaa näkymää",
216+
"editColumns": "Muokkaa sarakkeita",
216217
"delete": "Poista näkymä",
217218
"copy": "Kopio tiedostosta {name}",
218219
"deleteModal": {

polaris-react/locales/fr.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@
213213
"rename": "Renommer la vue",
214214
"duplicate": "Dupliquer la vue",
215215
"edit": "Modifier la vue",
216+
"editColumns": "Modifier les colonnes",
216217
"delete": "Supprimer la vue",
217218
"copy": "Copie de {name}",
218219
"deleteModal": {

polaris-react/locales/it.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@
213213
"rename": "Rinomina vista",
214214
"duplicate": "Duplica vista",
215215
"edit": "Modifica vista",
216+
"editColumns": "Modifica colonne",
216217
"delete": "Elimina vista",
217218
"copy": "Copia di {name}",
218219
"deleteModal": {

polaris-react/locales/ja.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@
213213
"rename": "ビューの名前を変更",
214214
"duplicate": "ビューを複製",
215215
"edit": "ビューを編集",
216+
"editColumns": "列を編集",
216217
"delete": "ビューを削除",
217218
"copy": "{name}のコピー",
218219
"deleteModal": {

0 commit comments

Comments
 (0)