Skip to content

[CheckableButton] Make se23 styles the default #10054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[CheckableButton] Make se23 styles the default #10054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions polaris-react/src/components/CheckableButton/CheckableButton.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
letter-spacing: initial;
display: flex;
align-items: center;
min-height: 36px;
min-width: 36px;
gap: calc(var(--p-space-3) + var(--p-space-025));
margin: 0;
cursor: pointer;
user-select: none;
Expand All @@ -19,13 +18,11 @@
border-radius: var(--p-border-radius-1);
width: auto;

#{$se23} & {
// Checkable Button has no opinion on its own height, it simply fills its
// container
min-height: auto;
min-width: auto;
height: 100%;
}
// Checkable Button has no opinion on its own height, it simply fills its
// container
min-height: auto;
min-width: auto;
height: 100%;

svg {
fill: var(--p-color-icon-on-color);
Expand Down Expand Up @@ -62,11 +59,6 @@
text-overflow: ellipsis;
// padding to fix the bottom of letters being cutoff by overflow: hidden
padding: var(--p-space-025) 0;
margin-left: calc(var(--p-space-5) - var(--p-border-width-2));

#{$se23} & {
margin-left: calc(var(--p-space-3) + var(--p-space-025));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to a gap declaration on the containing flex element.

// stylelint-disable-next-line polaris/typography/declaration-property-unit-disallowed-list -- se23
line-height: 18px;
}
// stylelint-disable-next-line polaris/typography/declaration-property-unit-disallowed-list -- se23
line-height: 18px;
}