This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Dynamic Fontsize for apple devices - target mobile only #10288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
approved these changes
Aug 31, 2023
kyledurand
approved these changes
Aug 31, 2023
Merged
kyledurand
pushed a commit
that referenced
this pull request
Aug 31, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.21.0 ### Minor Changes - [#10246](#10246) [`1947b4691`](1947b46) Thanks [@kyledurand](https://github.com/kyledurand)! - Added the ability to migrate prop values ### Patch Changes - [#10215](#10215) [`e4a6d47ab`](e4a6d47) Thanks [@aveline](https://github.com/aveline)! - Fixed a bug in the rename prop migration ## @shopify/polaris@11.14.0 ### Minor Changes - [#9907](#9907) [`ef7ddb4ac`](ef7ddb4) Thanks [@MaxCloutier](https://github.com/MaxCloutier)! - Add a search field to filter ActionList that have more than 10 items ### Patch Changes - [#10288](#10288) [`cd1578230`](cd15782) Thanks [@ssetem](https://github.com/ssetem)! - Only apply apple dynamic text to mobile breakpoint - [#10292](#10292) [`72f55e32f`](72f55e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added check for string type before calling string method - [#10211](#10211) [`ac044b3c9`](ac044b3) Thanks [@peterlazzarino](https://github.com/peterlazzarino)! - Ensure Avatar has no background color if an source prop is passed in to allow for transparent images - [#10287](#10287) [`9b14e231a`](9b14e23) Thanks [@laurkim](https://github.com/laurkim)! - Fixed focus ring and input text styles on `ActionList.SearchField` component ## polaris.shopify.com@0.57.2 ### Patch Changes - Updated dependencies \[[`ef7ddb4ac`](ef7ddb4), [`cd1578230`](cd15782), [`72f55e32f`](72f55e3), [`ac044b3c9`](ac044b3), [`9b14e231a`](9b14e23)]: - @shopify/polaris@11.14.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes an issue where Desktop Safari has a font scale which is too small. <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? We are wrapping the use of `font: -apple-system-body` within the mobile breakpoint to address the issue. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 **Desktop** 1. Visit [storybook](https://5d559397bae39100201eedc1-jcrahhpmju.chromatic.com/?path=/story/all-components-text--variants) in Desktop Safari 2. Open the Text Story 3. Ensure that the text size is normal 4. Double check with inspector and ensure `font:-apple-system-body` is not being applied **Mobile** 1. Visit [storybook](https://5d559397bae39100201eedc1-jcrahhpmju.chromatic.com/?path=/story/all-components-text--variants) in iOS Simulator 2. Open the Text Story 3. Within the inspector verify that `font: -apple-system-body` is being applied 4. Change the accessibility font size and verify text size updates correctly ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.21.0 ### Minor Changes - [Shopify#10246](Shopify#10246) [`1947b4691`](Shopify@6c32424) Thanks [@kyledurand](https://github.com/kyledurand)! - Added the ability to migrate prop values ### Patch Changes - [Shopify#10215](Shopify#10215) [`e4a6d47ab`](Shopify@3d4ef92) Thanks [@aveline](https://github.com/aveline)! - Fixed a bug in the rename prop migration ## @shopify/polaris@11.14.0 ### Minor Changes - [Shopify#9907](Shopify#9907) [`ef7ddb4ac`](Shopify@b621532) Thanks [@MaxCloutier](https://github.com/MaxCloutier)! - Add a search field to filter ActionList that have more than 10 items ### Patch Changes - [Shopify#10288](Shopify#10288) [`cd1578230`](Shopify@68ea269) Thanks [@ssetem](https://github.com/ssetem)! - Only apply apple dynamic text to mobile breakpoint - [Shopify#10292](Shopify#10292) [`72f55e32f`](Shopify@1a74207) Thanks [@kyledurand](https://github.com/kyledurand)! - Added check for string type before calling string method - [Shopify#10211](Shopify#10211) [`ac044b3c9`](Shopify@7a8d4ff) Thanks [@peterlazzarino](https://github.com/peterlazzarino)! - Ensure Avatar has no background color if an source prop is passed in to allow for transparent images - [Shopify#10287](Shopify#10287) [`9b14e231a`](Shopify@b9ff765) Thanks [@laurkim](https://github.com/laurkim)! - Fixed focus ring and input text styles on `ActionList.SearchField` component ## polaris.shopify.com@0.57.2 ### Patch Changes - Updated dependencies \[[`ef7ddb4ac`](Shopify@b621532), [`cd1578230`](Shopify@68ea269), [`72f55e32f`](Shopify@1a74207), [`ac044b3c9`](Shopify@7a8d4ff), [`9b14e231a`](Shopify@b9ff765)]: - @shopify/polaris@11.14.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes an issue where Desktop Safari has a font scale which is too small.
WHAT is this pull request doing?
We are wrapping the use of
font: -apple-system-bodywithin the mobile breakpoint to address the issue.How to 🎩
Desktop
font:-apple-system-bodyis not being appliedMobile
font: -apple-system-bodyis being applied🎩 checklist
README.mdwith documentation changes