Create migration for replacing v11 shadow custom properties
#10306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @lgriffee! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230922144839yarn add @shopify/polaris@0.0.0-snapshot-release-20230922144839yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230922144839yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230922144839 |
This was referenced Sep 22, 2023
chloerice
approved these changes
Sep 29, 2023
Merged
laurkim
pushed a commit
that referenced
this pull request
Oct 4, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.23.0 ### Minor Changes - [#10579](#10579) [`b5a3622ca`](b5a3622) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created migration to replace deprecated `color` custom properties in Polaris v12.0.0 - [#10304](#10304) [`eb93b7f1c`](eb93b7f) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `font` custom properties in polaris-react v12.0.0 - [#10506](#10506) [`d901a07a3`](d901a07) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `border` custom properties in polaris-react v12.0.0 - [#10305](#10305) [`1b36b9256`](1b36b92) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `space` custom properties in polaris-react v12.0.0 - [#10306](#10306) [`dbae87e58`](dbae87e) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `shadow` custom properties in polaris-react v12.0.0 ## @shopify/polaris@11.26.0 ### Minor Changes - [#10788](#10788) [`82f10e830`](82f10e8) Thanks [@mrcthms](https://github.com/mrcthms)! - Deprecated the IndexFiltersManager component ## polaris.shopify.com@0.58.5 ### Patch Changes - Updated dependencies \[[`82f10e830`](82f10e8)]: - @shopify/polaris@11.26.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
### WHY are these changes introduced? Fixes #10513 ### WHAT is this pull request doing? This PR creates a migration for deprecated `shadow` custom properties in v12 using the generic codemod [`styles-replace-custom-property`](#8265). #### v12-styles-replace-custom-property-shadow | Deprecated CSS Custom Property | Replacement Value | | ----------------------------------------- | ---------------------------------- | | `--p-shadow-inset-lg` | `--p-shadow-inset-200` | | `--p-shadow-inset-md` | `--p-shadow-inset-200` | | `--p-shadow-inset-sm` | `--p-shadow-inset-100` | | `--p-shadow-none` | `--p-shadow-0` | | `--p-shadow-xs` | `--p-shadow-100` | | `--p-shadow-sm` | `--p-shadow-200` | | `--p-shadow-md` | `--p-shadow-300` | | `--p-shadow-lg` | `--p-shadow-400` | | `--p-shadow-xl` | `--p-shadow-500` | | `--p-shadow-2xl` | `--p-shadow-600` | | `--p-shadow-bevel-experimental` | `--p-shadow-bevel-100` | | `--p-shadow-card-sm-experimental` | `--p-shadow-100` | | `--p-shadow-card-md-experimental` | `--p-shadow-200` | | `--p-shadow-card-lg-experimental` | `--p-shadow-300` | | `--p-shadow-button-experimental` | `--p-shadow-button` | | `--p-shadow-button-hover-experimental` | `--p-shadow-button-hover` | | `--p-shadow-button-disabled-experimental` | `inset 0 0 0 1px rgba(227, 227, 227, 1)` | | `--p-shadow-button-primary-strong-experimental` | `--p-shadow-button-primary` | | `--p-shadow-button-primary-strong-inset-experimental` | `--p-shadow-button-primary-inset` | | `--p-shadow-button-primary-strong-hover-experimental` | `--p-shadow-button-primary-hover` | | `--p-shadow-border-inset-experimental` | `--p-shadow-border-inset` | >[!IMPORTANT] >The following tokens need to be manually migrated because their values are context dependent. | Deprecated CSS Custom Property | Replacement Value | | ----------------------------------------- | ---------------------------------- | | `--p-shadow-button-primary-experimental` | `--p-shadow-button-primary-critical`<br>`--p-shadow-button-primary-success` | | `--p-shadow-button-primary-hover-experimental` | `--p-shadow-button-primary-critical-hover`<br>`--p-shadow-button-primary-success-hover` | | `--p-shadow-button-inset-experimental` | `--p-shadow-button-primary-critical-inset`<br>`--p-shadow-button-primary-success-inset` |
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. - [#10579](#10579) [`b5a3622ca`](b5a3622) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created migration to replace deprecated `color` custom properties in Polaris v12.0.0 - [#10304](#10304) [`eb93b7f1c`](eb93b7f) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `font` custom properties in polaris-react v12.0.0 - [#10506](#10506) [`d901a07a3`](d901a07) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `border` custom properties in polaris-react v12.0.0 - [#10305](#10305) [`1b36b9256`](1b36b92) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `space` custom properties in polaris-react v12.0.0 - [#10306](#10306) [`dbae87e58`](dbae87e) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `shadow` custom properties in polaris-react v12.0.0 - [#10788](#10788) [`82f10e830`](82f10e8) Thanks [@mrcthms](https://github.com/mrcthms)! - Deprecated the IndexFiltersManager component - Updated dependencies \[[`82f10e830`](82f10e8)]: - @shopify/polaris@11.26.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
### WHY are these changes introduced? Fixes #10513 ### WHAT is this pull request doing? This PR creates a migration for deprecated `shadow` custom properties in v12 using the generic codemod [`styles-replace-custom-property`](#8265). #### v12-styles-replace-custom-property-shadow | Deprecated CSS Custom Property | Replacement Value | | ----------------------------------------- | ---------------------------------- | | `--p-shadow-inset-lg` | `--p-shadow-inset-200` | | `--p-shadow-inset-md` | `--p-shadow-inset-200` | | `--p-shadow-inset-sm` | `--p-shadow-inset-100` | | `--p-shadow-none` | `--p-shadow-0` | | `--p-shadow-xs` | `--p-shadow-100` | | `--p-shadow-sm` | `--p-shadow-200` | | `--p-shadow-md` | `--p-shadow-300` | | `--p-shadow-lg` | `--p-shadow-400` | | `--p-shadow-xl` | `--p-shadow-500` | | `--p-shadow-2xl` | `--p-shadow-600` | | `--p-shadow-bevel-experimental` | `--p-shadow-bevel-100` | | `--p-shadow-card-sm-experimental` | `--p-shadow-100` | | `--p-shadow-card-md-experimental` | `--p-shadow-200` | | `--p-shadow-card-lg-experimental` | `--p-shadow-300` | | `--p-shadow-button-experimental` | `--p-shadow-button` | | `--p-shadow-button-hover-experimental` | `--p-shadow-button-hover` | | `--p-shadow-button-disabled-experimental` | `inset 0 0 0 1px rgba(227, 227, 227, 1)` | | `--p-shadow-button-primary-strong-experimental` | `--p-shadow-button-primary` | | `--p-shadow-button-primary-strong-inset-experimental` | `--p-shadow-button-primary-inset` | | `--p-shadow-button-primary-strong-hover-experimental` | `--p-shadow-button-primary-hover` | | `--p-shadow-border-inset-experimental` | `--p-shadow-border-inset` | >[!IMPORTANT] >The following tokens need to be manually migrated because their values are context dependent. | Deprecated CSS Custom Property | Replacement Value | | ----------------------------------------- | ---------------------------------- | | `--p-shadow-button-primary-experimental` | `--p-shadow-button-primary-critical`<br>`--p-shadow-button-primary-success` | | `--p-shadow-button-primary-hover-experimental` | `--p-shadow-button-primary-critical-hover`<br>`--p-shadow-button-primary-success-hover` | | `--p-shadow-button-inset-experimental` | `--p-shadow-button-primary-critical-inset`<br>`--p-shadow-button-primary-success-inset` |
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. - [#10579](#10579) [`b5a3622ca`](b5a3622) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created migration to replace deprecated `color` custom properties in Polaris v12.0.0 - [#10304](#10304) [`eb93b7f1c`](eb93b7f) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `font` custom properties in polaris-react v12.0.0 - [#10506](#10506) [`d901a07a3`](d901a07) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `border` custom properties in polaris-react v12.0.0 - [#10305](#10305) [`1b36b9256`](1b36b92) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `space` custom properties in polaris-react v12.0.0 - [#10306](#10306) [`dbae87e58`](dbae87e) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `shadow` custom properties in polaris-react v12.0.0 - [#10788](#10788) [`82f10e830`](82f10e8) Thanks [@mrcthms](https://github.com/mrcthms)! - Deprecated the IndexFiltersManager component - Updated dependencies \[[`82f10e830`](82f10e8)]: - @shopify/polaris@11.26.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…y#10306) ### WHY are these changes introduced? Fixes Shopify#10513 ### WHAT is this pull request doing? This PR creates a migration for deprecated `shadow` custom properties in v12 using the generic codemod [`styles-replace-custom-property`](Shopify#8265). #### v12-styles-replace-custom-property-shadow | Deprecated CSS Custom Property | Replacement Value | | ----------------------------------------- | ---------------------------------- | | `--p-shadow-inset-lg` | `--p-shadow-inset-200` | | `--p-shadow-inset-md` | `--p-shadow-inset-200` | | `--p-shadow-inset-sm` | `--p-shadow-inset-100` | | `--p-shadow-none` | `--p-shadow-0` | | `--p-shadow-xs` | `--p-shadow-100` | | `--p-shadow-sm` | `--p-shadow-200` | | `--p-shadow-md` | `--p-shadow-300` | | `--p-shadow-lg` | `--p-shadow-400` | | `--p-shadow-xl` | `--p-shadow-500` | | `--p-shadow-2xl` | `--p-shadow-600` | | `--p-shadow-bevel-experimental` | `--p-shadow-bevel-100` | | `--p-shadow-card-sm-experimental` | `--p-shadow-100` | | `--p-shadow-card-md-experimental` | `--p-shadow-200` | | `--p-shadow-card-lg-experimental` | `--p-shadow-300` | | `--p-shadow-button-experimental` | `--p-shadow-button` | | `--p-shadow-button-hover-experimental` | `--p-shadow-button-hover` | | `--p-shadow-button-disabled-experimental` | `inset 0 0 0 1px rgba(227, 227, 227, 1)` | | `--p-shadow-button-primary-strong-experimental` | `--p-shadow-button-primary` | | `--p-shadow-button-primary-strong-inset-experimental` | `--p-shadow-button-primary-inset` | | `--p-shadow-button-primary-strong-hover-experimental` | `--p-shadow-button-primary-hover` | | `--p-shadow-border-inset-experimental` | `--p-shadow-border-inset` | >[!IMPORTANT] >The following tokens need to be manually migrated because their values are context dependent. | Deprecated CSS Custom Property | Replacement Value | | ----------------------------------------- | ---------------------------------- | | `--p-shadow-button-primary-experimental` | `--p-shadow-button-primary-critical`<br>`--p-shadow-button-primary-success` | | `--p-shadow-button-primary-hover-experimental` | `--p-shadow-button-primary-critical-hover`<br>`--p-shadow-button-primary-success-hover` | | `--p-shadow-button-inset-experimental` | `--p-shadow-button-primary-critical-inset`<br>`--p-shadow-button-primary-success-inset` |
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.23.0 ### Minor Changes - [Shopify#10579](Shopify#10579) [`b5a3622ca`](Shopify@6db4ec7) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created migration to replace deprecated `color` custom properties in Polaris v12.0.0 - [Shopify#10304](Shopify#10304) [`eb93b7f1c`](Shopify@b86cc31) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `font` custom properties in polaris-react v12.0.0 - [Shopify#10506](Shopify#10506) [`d901a07a3`](Shopify@ffaebbd) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `border` custom properties in polaris-react v12.0.0 - [Shopify#10305](Shopify#10305) [`1b36b9256`](Shopify@0d403c8) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `space` custom properties in polaris-react v12.0.0 - [Shopify#10306](Shopify#10306) [`dbae87e58`](Shopify@fb524c2) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `shadow` custom properties in polaris-react v12.0.0 ## @shopify/polaris@11.26.0 ### Minor Changes - [Shopify#10788](Shopify#10788) [`82f10e830`](Shopify@c937a3a) Thanks [@mrcthms](https://github.com/mrcthms)! - Deprecated the IndexFiltersManager component ## polaris.shopify.com@0.58.5 ### Patch Changes - Updated dependencies \[[`82f10e830`](Shopify@c937a3a)]: - @shopify/polaris@11.26.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #10513
WHAT is this pull request doing?
This PR creates a migration for deprecated
shadowcustom properties in v12 using the generic codemodstyles-replace-custom-property.v12-styles-replace-custom-property-shadow
--p-shadow-inset-lg--p-shadow-inset-200--p-shadow-inset-md--p-shadow-inset-200--p-shadow-inset-sm--p-shadow-inset-100--p-shadow-none--p-shadow-0--p-shadow-xs--p-shadow-100--p-shadow-sm--p-shadow-200--p-shadow-md--p-shadow-300--p-shadow-lg--p-shadow-400--p-shadow-xl--p-shadow-500--p-shadow-2xl--p-shadow-600--p-shadow-bevel-experimental--p-shadow-bevel-100--p-shadow-card-sm-experimental--p-shadow-100--p-shadow-card-md-experimental--p-shadow-200--p-shadow-card-lg-experimental--p-shadow-300--p-shadow-button-experimental--p-shadow-button--p-shadow-button-hover-experimental--p-shadow-button-hover--p-shadow-button-disabled-experimentalinset 0 0 0 1px rgba(227, 227, 227, 1)--p-shadow-button-primary-strong-experimental--p-shadow-button-primary--p-shadow-button-primary-strong-inset-experimental--p-shadow-button-primary-inset--p-shadow-button-primary-strong-hover-experimental--p-shadow-button-primary-hover--p-shadow-border-inset-experimental--p-shadow-border-insetImportant
The following tokens need to be manually migrated because their values are context dependent.
--p-shadow-button-primary-experimental--p-shadow-button-primary-critical--p-shadow-button-primary-success--p-shadow-button-primary-hover-experimental--p-shadow-button-primary-critical-hover--p-shadow-button-primary-success-hover--p-shadow-button-inset-experimental--p-shadow-button-primary-critical-inset--p-shadow-button-primary-success-inset