Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Conversation

aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented Sep 19, 2023

WHY are these changes introduced?

Part of #10528

WHAT is this pull request doing?

Migrated CSS custom properties for color token groups.

See #10528 for detailed instructions on the migration process and replacement maps.

Polaris migrator snapshot ran on this PR:

cd polaris-react

npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230920224230 \
  v12-styles-replace-custom-property-color \
  'src/**/*'

@aaronccasanova aaronccasanova changed the title Migrate color custom properties Migrate color custom properties from Polaris v11 to v12 Sep 19, 2023
@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230920231822
yarn add @shopify/polaris@0.0.0-snapshot-release-20230920231822
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230920231822
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230920231822

@aaronccasanova aaronccasanova marked this pull request as ready for review September 21, 2023 00:04
@aaronccasanova aaronccasanova self-assigned this Sep 21, 2023
Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈 🚀

Copy link
Contributor

@sarahill sarahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🌈

@aaronccasanova aaronccasanova force-pushed the migrate-custom-properties-color branch from 0cc0cc5 to 9751c58 Compare September 25, 2023 23:15
@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230925232918
yarn add @shopify/polaris@0.0.0-snapshot-release-20230925232918
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230925232918
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230925232918

@aaronccasanova aaronccasanova force-pushed the migrate-custom-properties-color branch from 7c09c05 to 27728d5 Compare September 27, 2023 20:07
@aaronccasanova aaronccasanova requested review from a team as code owners September 27, 2023 20:07
@aaronccasanova aaronccasanova merged commit 30555a9 into main Sep 27, 2023
@aaronccasanova aaronccasanova deleted the migrate-custom-properties-color branch September 27, 2023 20:24
aaronccasanova added a commit that referenced this pull request Sep 27, 2023
…ndefined" (#10734)

Reverts #10711

Temporarily reverting this PR so the [color
migration](#10576) can be on a
dedicated release.
aaronccasanova pushed a commit that referenced this pull request Sep 27, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@11.24.0

### Minor Changes

- [#10576](#10576)
[`30555a9f9`](30555a9)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Migrated
`color` custom properties from Polaris v11 to v12


-
[`b3bfdcfc0`](b3bfdcf)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - - Updated
the `TextField` to automatically set password manager disable data
attributes when `autoComplete` is set to "off"
    -   Deprecated the `TextField` `disable1Password` prop

## polaris.shopify.com@0.58.3

### Patch Changes

- Updated dependencies
\[[`30555a9f9`](30555a9),
[`b3bfdcfc0`](b3bfdcf)]:
    -   @shopify/polaris@11.24.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
)

### WHY are these changes introduced?

Part of Shopify#10528

### WHAT is this pull request doing?

Migrated CSS custom properties for `color` token groups.

> See Shopify#10528 for detailed
instructions on the migration process and replacement maps.

Polaris migrator snapshot ran on this PR:
```sh
cd polaris-react

npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230920224230 \
  v12-styles-replace-custom-property-color \
  'src/**/*'
```
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
…ndefined" (Shopify#10734)

Reverts Shopify#10711

Temporarily reverting this PR so the [color
migration](Shopify#10576) can be on a
dedicated release.
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@11.24.0

### Minor Changes

- [Shopify#10576](Shopify#10576)
[`30555a9f9`](Shopify@4c2791d)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Migrated
`color` custom properties from Polaris v11 to v12


-
[`b3bfdcfc0`](Shopify@0bf352b)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - - Updated
the `TextField` to automatically set password manager disable data
attributes when `autoComplete` is set to "off"
    -   Deprecated the `TextField` `disable1Password` prop

## polaris.shopify.com@0.58.3

### Patch Changes

- Updated dependencies
\[[`30555a9f9`](Shopify@4c2791d),
[`b3bfdcfc0`](Shopify@0bf352b)]:
    -   @shopify/polaris@11.24.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants