[Page] Revert page action disabling when in IndexFilter's filter mode

.changeset/kind-lemons-jump.md

@@ -0,0 +1,5 @@
+---
+'@shopify/polaris': patch
+---
+
+Reverted disabling of `Page` `secondaryActions` when `IndexFilters` is in filter `mode`

polaris-react/src/components/Page/components/Header/Header.tsx

@@ -26,10 +26,6 @@ import type {PaginationProps} from '../../../Pagination';
 import {ActionMenu, hasGroupsWithActions} from '../../../ActionMenu';
 import {isInterface} from '../../../../utilities/is-interface';
 import {isReactElement} from '../../../../utilities/is-react-element';
-import {
-  IndexFiltersMode,
-  useSetIndexFiltersMode,
-} from '../../../../utilities/index-filters';
 import {Box} from '../../../Box';
 import {HorizontalStack} from '../../../HorizontalStack';
 import {useFeatures} from '../../../../utilities/features';
@@ -97,8 +93,6 @@ export function Header({
   const i18n = useI18n();
   const {polarisSummerEditions2023} = useFeatures();
   const {isNavigationCollapsed} = useMediaQuery();
-  const {mode} = useSetIndexFiltersMode();
-  const disableActions = mode !== IndexFiltersMode.Default;
 
   if (additionalNavigation && process.env.NODE_ENV === 'development') {
     // eslint-disable-next-line no-console
@@ -132,8 +126,8 @@ export function Header({
         <Box printHidden>
           <Pagination
             {...pagination}
-            hasPrevious={disableActions ? false : pagination.hasPrevious}
-            hasNext={disableActions ? false : pagination.hasNext}
+            hasPrevious={pagination.hasPrevious}
+            hasNext={pagination.hasNext}
           />
         </Box>
       </div>
@@ -157,10 +151,7 @@ export function Header({
   );
 
   const primaryActionMarkup = primaryAction ? (
-    <PrimaryActionMarkup
-      primaryAction={primaryAction}
-      disabled={disableActions}
-    />
+    <PrimaryActionMarkup primaryAction={primaryAction} />
   ) : null;
 
   let actionMenuMarkup: MaybeJSX = null;
@@ -170,14 +161,8 @@ export function Header({
   ) {
     actionMenuMarkup = (
       <ActionMenu
-        actions={secondaryActions.map((secondaryAction) => ({
-          ...secondaryAction,
-          disabled: disableActions || secondaryAction.disabled,
-        }))}
-        groups={actionGroups.map((actionGroup) => ({
-          ...actionGroup,
-          disabled: disableActions || actionGroup.disabled,
-        }))}
+        actions={secondaryActions}
+        groups={actionGroups}
         rollup={isNavigationCollapsed}
         rollupActionsLabel={
           title
@@ -290,10 +275,8 @@ export function Header({
 
 function PrimaryActionMarkup({
   primaryAction,
-  disabled,
 }: {
   primaryAction: PrimaryAction | React.ReactNode;
-  disabled: boolean;
 }) {
   const {isNavigationCollapsed} = useMediaQuery();
 
@@ -305,7 +288,6 @@ function PrimaryActionMarkup({
       shouldShowIconOnly(isNavigationCollapsed, primaryAction),
       {
         primary,
-        disabled: disabled || primaryAction.disabled,
       },
     );
 

polaris-react/src/components/Page/components/Header/tests/Header.test.tsx

@@ -12,7 +12,6 @@ import {Tooltip} from '../../../../Tooltip';
 import type {LinkAction, MenuActionDescriptor} from '../../../../../types';
 import {Header} from '../Header';
 import type {HeaderProps} from '../Header';
-import {IndexFiltersMode} from '../../../../../utilities/index-filters';
 
 describe('<Header />', () => {
   const mockProps: HeaderProps = {
@@ -116,26 +115,6 @@ describe('<Header />', () => {
       });
     });
 
-    it('renders a disabled button when a non-default IndexFiltersMode is set', () => {
-      const primaryAction: HeaderProps['primaryAction'] = {
-        content: buttonContent,
-      };
-
-      const header = mountWithApp(
-        <Header {...mockProps} primaryAction={primaryAction} />,
-        {
-          indexFilters: {
-            mode: IndexFiltersMode.Filtering,
-          },
-        },
-      );
-
-      expect(header).toContainReactComponent(Button, {
-        disabled: true,
-        children: buttonContent,
-      });
-    });
-
     it('renders a `ReactNode`', () => {
       const PrimaryAction = () => null;
 
@@ -174,27 +153,6 @@ describe('<Header />', () => {
         hasNext: true,
       });
     });
-
-    it('adds false values for hasNext and hasPrevious when a non-default IndexFiltersMode is set', () => {
-      const pagination = {
-        hasNext: true,
-        hasPrevious: true,
-      };
-
-      const header = mountWithApp(
-        <Header {...mockProps} pagination={pagination} />,
-        {
-          indexFilters: {
-            mode: IndexFiltersMode.Filtering,
-          },
-        },
-      );
-
-      expect(header).toContainReactComponent(Pagination, {
-        hasNext: false,
-        hasPrevious: false,
-      });
-    });
   });
 
   describe('actionGroups', () => {
@@ -222,24 +180,6 @@ describe('<Header />', () => {
         groups: mockActionGroups,
       });
     });
-
-    it('disables actions within the actionGroups when a non-default IndexFiltersMode is set', () => {
-      const wrapper = mountWithApp(
-        <Header {...mockProps} actionGroups={mockActionGroups} />,
-        {
-          indexFilters: {
-            mode: IndexFiltersMode.Filtering,
-          },
-        },
-      );
-
-      expect(wrapper).toContainReactComponent(ActionMenu, {
-        groups: mockActionGroups.map((actionGroup) => ({
-          ...actionGroup,
-          disabled: true,
-        })),
-      });
-    });
   });
 
   describe('additionalNavigation', () => {