This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Modal] Only announce toast messages if frame context exists #10665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
chloerice
force-pushed
the
fail-frame-context-in-modal-gracefully
branch
from
dc7d220 to
a945d1e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
/snapit |
sophschneider
approved these changes
Sep 25, 2023
chloerice
added
Bug
aaronccasanova
approved these changes
Sep 25, 2023
|
🫰✨ Thanks @chloerice! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230925185923yarn add @shopify/polaris@0.0.0-snapshot-release-20230925185923yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230925185923yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230925185923 |
|
Tophatted by opening a few modals in web, LGTM! no console errors |
Merged
sophschneider
pushed a commit
that referenced
this pull request
Sep 25, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-tokens@7.11.0 ### Minor Changes - [#10647](#10647) [`f26cebe99`](f26cebe) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added composite `text` and `font-letter-spacing` tokens - [#10643](#10643) [`2359e5f5a`](2359e5f) Thanks [@lgriffee](https://github.com/lgriffee)! - Added semantic `space` token scale ## @shopify/polaris-migrator@0.22.6 ### Patch Changes - Updated dependencies \[[`f26cebe99`](f26cebe), [`2359e5f5a`](2359e5f)]: - @shopify/polaris-tokens@7.11.0 - @shopify/stylelint-polaris@14.0.6 ## @shopify/polaris@11.20.1 ### Patch Changes - [#10665](#10665) [`22dbada34`](22dbada) Thanks [@chloerice](https://github.com/chloerice)! - Fixed `Modal` missing `FrameContext` error - [#10663](#10663) [`f6a965102`](f6a9651) Thanks [@chloerice](https://github.com/chloerice)! - Reverted disabling of `Page` `secondaryActions` when `IndexFilters` is in filter `mode` - [#10649](#10649) [`3bafbea50`](3bafbea) Thanks [@mattkubej](https://github.com/mattkubej)! - Replace usages of `bg-secondary-experimental` with `bg-subdued` for Tables - Updated dependencies \[[`f26cebe99`](f26cebe), [`2359e5f5a`](2359e5f)]: - @shopify/polaris-tokens@7.11.0 ## @shopify/stylelint-polaris@14.0.6 ### Patch Changes - Updated dependencies \[[`f26cebe99`](f26cebe), [`2359e5f5a`](2359e5f)]: - @shopify/polaris-tokens@7.11.0 ## polaris-for-vscode@0.8.0 ### Minor Changes - [#10647](#10647) [`f26cebe99`](f26cebe) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added composite `text` token completions ## polaris.shopify.com@0.57.9 ### Patch Changes - [#10609](#10609) [`b53189c72`](b53189c) Thanks [@kyledurand](https://github.com/kyledurand)! - Updated component example backgrounds - Updated dependencies \[[`22dbada34`](22dbada), [`f26cebe99`](f26cebe), [`f6a965102`](f6a9651), [`3bafbea50`](3bafbea), [`2359e5f5a`](2359e5f)]: - @shopify/polaris@11.20.1 - @shopify/polaris-tokens@7.11.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
chloerice
added
2023
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…#10665) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes `Modal` erroring on render if not wrapped in a `Frame`. <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-tokens@7.11.0 ### Minor Changes - [Shopify#10647](Shopify#10647) [`f26cebe99`](Shopify@b384a49) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added composite `text` and `font-letter-spacing` tokens - [Shopify#10643](Shopify#10643) [`2359e5f5a`](Shopify@ba2f01a) Thanks [@lgriffee](https://github.com/lgriffee)! - Added semantic `space` token scale ## @shopify/polaris-migrator@0.22.6 ### Patch Changes - Updated dependencies \[[`f26cebe99`](Shopify@b384a49), [`2359e5f5a`](Shopify@ba2f01a)]: - @shopify/polaris-tokens@7.11.0 - @shopify/stylelint-polaris@14.0.6 ## @shopify/polaris@11.20.1 ### Patch Changes - [Shopify#10665](Shopify#10665) [`22dbada34`](Shopify@d4bf751) Thanks [@chloerice](https://github.com/chloerice)! - Fixed `Modal` missing `FrameContext` error - [Shopify#10663](Shopify#10663) [`f6a965102`](Shopify@8a46514) Thanks [@chloerice](https://github.com/chloerice)! - Reverted disabling of `Page` `secondaryActions` when `IndexFilters` is in filter `mode` - [Shopify#10649](Shopify#10649) [`3bafbea50`](Shopify@6c81246) Thanks [@mattkubej](https://github.com/mattkubej)! - Replace usages of `bg-secondary-experimental` with `bg-subdued` for Tables - Updated dependencies \[[`f26cebe99`](Shopify@b384a49), [`2359e5f5a`](Shopify@ba2f01a)]: - @shopify/polaris-tokens@7.11.0 ## @shopify/stylelint-polaris@14.0.6 ### Patch Changes - Updated dependencies \[[`f26cebe99`](Shopify@b384a49), [`2359e5f5a`](Shopify@ba2f01a)]: - @shopify/polaris-tokens@7.11.0 ## polaris-for-vscode@0.8.0 ### Minor Changes - [Shopify#10647](Shopify#10647) [`f26cebe99`](Shopify@b384a49) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added composite `text` token completions ## polaris.shopify.com@0.57.9 ### Patch Changes - [Shopify#10609](Shopify#10609) [`b53189c72`](Shopify@82d23cc) Thanks [@kyledurand](https://github.com/kyledurand)! - Updated component example backgrounds - Updated dependencies \[[`22dbada34`](Shopify@d4bf751), [`f26cebe99`](Shopify@b384a49), [`f6a965102`](Shopify@8a46514), [`3bafbea50`](Shopify@6c81246), [`2359e5f5a`](Shopify@ba2f01a)]: - @shopify/polaris@11.20.1 - @shopify/polaris-tokens@7.11.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes
Modalerroring on render if not wrapped in aFrame. Related to #10406.🌀 Spinstance
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes