This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Revert "Revert "[Filters] Fix hitting max call depth when appliedFilters is undefined"" #10736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Any chance this can be shipped today please? Also - for future reverts, is it possible to ping the original PR author on them for visibility/awareness please? |
aaronccasanova
deleted the
revert-10734-revert-10711-fix/filter-max-call-depth
branch
This was referenced Sep 28, 2023
Merged
chloerice
pushed a commit
that referenced
this pull request
Sep 28, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.25.0 ### Minor Changes - [#10724](#10724) [`7e53d7860`](7e53d78) Thanks [@chloerice](https://github.com/chloerice)! - Deprecated `IndexTable` `status` and `subdued` props in favor of new `tone` prop ### Patch Changes - [#10736](#10736) [`49e47880a`](49e4788) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Fixed issue with setting local pinned filters in `Filters` when no `appliedFilters` were provided. ## polaris.shopify.com@0.58.4 ### Patch Changes - Updated dependencies \[[`49e47880a`](49e4788), [`7e53d7860`](7e53d78)]: - @shopify/polaris@11.25.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…ers is undefined"" (Shopify#10736) Reverts Shopify#10734
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.25.0 ### Minor Changes - [Shopify#10724](Shopify#10724) [`7e53d7860`](Shopify@9af4ce5) Thanks [@chloerice](https://github.com/chloerice)! - Deprecated `IndexTable` `status` and `subdued` props in favor of new `tone` prop ### Patch Changes - [Shopify#10736](Shopify#10736) [`49e47880a`](Shopify@7e02285) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Fixed issue with setting local pinned filters in `Filters` when no `appliedFilters` were provided. ## polaris.shopify.com@0.58.4 ### Patch Changes - Updated dependencies \[[`49e47880a`](Shopify@7e02285), [`7e53d7860`](Shopify@9af4ce5)]: - @shopify/polaris@11.25.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10734