Skip to content

Fix button disabled state on monochrome variant #10934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix button disabled state on monochrome variant #10934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5faa5b
fix(button): disabled state on monochrome variant
gazjones00 Oct 9, 2023
566026a
chore: implement feedback
gazjones00 Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-cameras-fry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed disabled state for `monochromePlain` variant in `Button`
3 changes: 1 addition & 2 deletions polaris-react/src/components/Button/Button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,8 +956,7 @@
}

&.disabled {
color: currentColor;
opacity: 0.4;
color: var(--p-color-text-disabled);

svg {
fill: currentColor;
Expand Down
6 changes: 6 additions & 0 deletions polaris-react/src/components/Button/Button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,12 @@ export function DisabledState() {
<Button variant="plain" tone="critical" disabled>
Buy shipping label
</Button>
{/* Visual check to ensure the button color is not inherited from the parent */}
<Box color="text-critical">
<Button variant="monochromePlain" disabled>
Buy shipping label
</Button>
</Box>
</ButtonGroup>
);
}
Expand Down