Skip to content

Fix incompatible types between IndexTable and useIndexResourceState #10993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix incompatible types between IndexTable and useIndexResourceState #10993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lovely-snakes-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed incompatible type between IndexTable and useIndexResourceState
2 changes: 2 additions & 0 deletions polaris-react/src/utilities/use-index-resource-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export function useIndexResourceState<T extends {[key: string]: unknown}>(
selectionType: SelectionType,
isSelecting: boolean,
selection?: string | Range,
// This is not used in the function, but needed to keep the type compatible with IndexProviderProps onSelectionChange
_position?: number,
) => {
if (selectionType === SelectionType.All) {
setAllResourcesSelected(isSelecting);
Expand Down