Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-crabs-rhyme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed `Tag` icon and disabled state colors
7 changes: 3 additions & 4 deletions polaris-react/src/components/Tag/Tag.scss
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ $button-size: 20px;
cursor: default;
pointer-events: none;
color: var(--p-color-text-disabled);
border: var(--p-border-width-025) solid var(--p-color-border-tertiary);
}

@media #{$p-breakpoints-sm-up} {
Expand Down Expand Up @@ -121,7 +120,7 @@ $button-size: 20px;

&:hover {
background: var(--p-color-bg-fill-tertiary-hover);
color: var(--p-color-icon-active);
color: var(--p-color-icon-hover);
outline: var(--p-border-width-025) solid transparent;
}

Expand All @@ -130,7 +129,7 @@ $button-size: 20px;

&:focus-visible {
background: var(--p-color-bg-fill-tertiary-hover);
color: var(--p-color-icon-active);
color: var(--p-color-icon-hover);
}

&:focus-visible:not(:active) {
Expand All @@ -147,7 +146,7 @@ $button-size: 20px;
pointer-events: none;

svg {
fill: currentColor;
fill: var(--p-color-icon-disabled);
}
}
}
Expand Down
12 changes: 7 additions & 5 deletions polaris-react/src/components/Tag/Tag.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, {useCallback, useState} from 'react';
import type {ComponentMeta} from '@storybook/react';
import {InlineStack, Icon, LegacyStack, Tag} from '@shopify/polaris';
import {Wand} from '@shopify/polaris-icons';
import {InlineStack, Icon, LegacyStack, Tag, Bleed} from '@shopify/polaris';
import {Magic} from '@shopify/polaris-icons';

export default {
component: Tag,
Expand Down Expand Up @@ -66,10 +66,12 @@ export function WithLink() {
export function WithCustomContent() {
return (
<Tag url="#">
<LegacyStack spacing="extraTight">
<Icon source={Wand} />
<InlineStack gap="050">
<Bleed marginInlineStart="100">
<Icon tone="base" source={Magic} />
</Bleed>
<span>Wholesale</span>
</LegacyStack>
</InlineStack>
</Tag>
);
}
Expand Down