This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Update metaobject icons with the latest from the uplifted icons #11119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainihas
force-pushed
the
update-metaobject-icon
branch
3 times, most recently
from
dc9f054 to
8f6db0d
Compare
elsom25
approved these changes
Nov 6, 2023
mkoenig-shopify
approved these changes
Nov 6, 2023
heyjoethomas
approved these changes
Nov 6, 2023
sainihas
force-pushed
the
update-metaobject-icon
branch
2 times, most recently
from
3d1fb48 to
cca215c
Compare
sainihas
force-pushed
the
update-metaobject-icon
branch
from
cca215c to
2821225
Compare
Merged
alex-page
added a commit
that referenced
this pull request
Nov 8, 2023
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…ify#11119) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? The current metaobject icons are not aligned with the [uplifted icons in Figma](https://www.figma.com/file/fVIazfJNe3AOJTJmBKgTO9/Polaris-Gen-3-Icons?type=design&node-id=11505%3A221&mode=dev) This PR updates them to align it with FIgma. | From Figma | From prod | | ------------- | ------------- | | <img width="393" alt="Screenshot 2023-11-06 at 4 45 41 PM" src="https://github.com/Shopify/polaris/assets/41344212/454b5013-2b16-49bc-a801-547643bc8894"> | <img width="209" alt="Screenshot 2023-11-06 at 4 45 57 PM" src="https://github.com/Shopify/polaris/assets/41344212/eb2eb211-e700-4e32-9348-7ff6ffcc09d5"> | ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…ns (Shopify#11119)" This reverts commit 26f2ced.
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
…ify#11136) Bringing the changes from Shopify#11119 back into the `main` branch with the old names. Thanks @sainihas for the contribution! Co-authored-by: Sai Nihas <41344212+sainihas@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The current metaobject icons are not aligned with the uplifted icons in Figma
This PR updates them to align it with FIgma.
🎩 checklist
README.mdwith documentation changes