Skip to content

[Button] Clean up stories #11129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2023
Merged

[Button] Clean up stories #11129

merged 2 commits into from
Nov 15, 2023

Conversation

kyledurand
Copy link
Member

No description provided.

@kyledurand kyledurand added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Nov 7, 2023
@aveline
Copy link
Contributor

aveline commented Nov 7, 2023

Is there a reason for paring down the examples? For example now Destructive only renders the default button instead of also showing destructive with icon, icon only, etc. I think it's worth keeping those because there can be unintended changes with icon colors etc between the variants and it helps to track any visual diffs.

@kyledurand
Copy link
Member Author

kyledurand commented Nov 7, 2023 •
edited
Loading

For sure. We want to keep the examples but pare down the code so it's more maintainable. I put this PR up pretty quick, and I'll address the comments

@kyledurand kyledurand force-pushed the fix-button-stories branch 2 times, most recently from 89fc2c8 to cf51d49 Compare November 15, 2023 13:43
sophschneider
sophschneider approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@sophschneider sophschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️ Nice cleanup! 🧹

@kyledurand kyledurand merged commit 65ad410 into main Nov 15, 2023
@kyledurand kyledurand deleted the fix-button-stories branch November 15, 2023 19:29
sam-b-rose added a commit that referenced this pull request Nov 15, 2023
@sam-b-rose
Merge branch 'main' into polaris-icons-v8
5894cb0 
* main:
  [Button] Clean up stories (#11129)
  [Box] Add support for `paddingInline` and `paddingBlock` (#11170)
  Add zero tokens for consistency as per team decision
  Add `key` prop to `Select` component option (#11172)
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@kyledurand
[Button] Clean up stories (Shopify#11129)
665adf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophschneider sophschneider sophschneider approved these changes

@aveline aveline Awaiting requested review from aveline

Assignees
No one assigned
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyledurand @aveline @sophschneider