Skip to content

[Pagination] Update height #11221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2023
Merged

[Pagination] Update height #11221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5175bcf
chore: update pagination height
mrcthms Nov 23, 2023
2899037
chore: changest
mrcthms Nov 23, 2023
cc5df17
chore: use height token
mrcthms Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strange-rats-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': minor
---

Updated Pagination to be correct height of 40px when in the table variant
2 changes: 1 addition & 1 deletion polaris-react/src/components/Pagination/Pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
border-top: 1px solid var(--p-color-border);

button {
--button-min-height: var(--p-space-600);
--button-min-height: var(--p-height-700);
background-color: var(--p-color-bg-surface-secondary);
min-height: var(--button-min-height);
min-width: var(--button-min-height);
Expand Down