Revert Tooltip updates to close on child enter/space key interactions #11800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronccasanova
requested review from
sam-b-rose,
chloerice,
sarahill,
sophschneider and
laurkim
aaronccasanova
added
the
🤖Skip Changelog
sam-b-rose
approved these changes
Mar 28, 2024
aaronccasanova
changed the title
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
This PR reverts the
Tooltipupdates made in PR# 11645 in favor of using the existingactiveprop. The original PR added support for dismissing theTooltipon child enter/space key interactions (e.g. when a copy to clipboard button is pressed). However, we later realized we can simply set theactiveprop tofalsefor the duration of the copied timeout.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes