Skip to content

[IndexTable] Conditionally render loadingMarkup on loading prop change #11806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[IndexTable] Conditionally render loadingMarkup on loading prop change #11806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75ee234
conditionally render loading markup
Mar 29, 2024
56a7fc1
changeset
Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-gorillas-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

[IndexTable] Conditionally render loading markup to fix loading component
4 changes: 2 additions & 2 deletions polaris-react/src/components/IndexTable/IndexTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ function IndexTableBase({
exitActive: styles['LoadingContainer-exit-active'],
};

const loadingMarkup = (
const loadingMarkup = loading ? (
<CSSTransition
in={loading}
classNames={loadingTransitionClassNames}
Expand All @@ -571,7 +571,7 @@ function IndexTableBase({
</div>
</div>
</CSSTransition>
);
) : null;

const stickyTableClassNames = classNames(
styles.StickyTable,
Expand Down