This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Text] Bring back heading2xl and associated tokens for mobile use-cases
#11815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgriffee
changed the title
heading2xl for mobile use-casesheading2xl and associated tokens for mobile use-cases
|
Chromatic changes LGTM! There are a few other changes sneaking in from other updates on the v13 branch but all look good! |
heyjoethomas
approved these changes
Apr 2, 2024
lgriffee
added a commit
that referenced
this pull request
Apr 2, 2024
…ion (#11813) ### WHY are these changes introduced? Part of https://github.com/Shopify/polaris-internal/issues/1529 ### WHAT is this pull request doing? This PR updates the migration for deprecated `font` custom properties based on the undeprecation of heading2xl. #### v14-styles-replace-custom-property-font | Deprecated CSS Custom Property | Replacement Value | | -- | -- | | ~`--p-font-size-750`~ | ~`--p-font-size-600`~ | | `--p-font-size-800` | ~`--p-font-size-600`~<br>`--p-font-size-750` | | `--p-font-size-900` | ~`--p-font-size-600`~<br>`--p-font-size-750` | | `--p-font-size-1000` | ~`--p-font-size-600`~<br>`--p-font-size-750` | | ~`--p-font-letter-spacing-denser`~ | ~`--p-font-letter-spacing-dense`~ | | `--p-font-letter-spacing-densest` | ~`--p-font-letter-spacing-dense`~<br>`--p-font-letter-spacing-denser` | | ~`--p-font-line-height-1000`~ | ~`--p-font-line-height-800`~ | | `--p-font-line-height-1200` | ~`--p-font-line-height-800`~<br>`--p-font-line-height-1000` | |`--p-text-heading-3xl-font-family`| ~`--p-text-heading-xl-font-family`~<br>`--p-text-heading-2xl-font-family`| |`--p-text-heading-3xl-font-size`| ~`--p-text-heading-xl-font-size`~<br>`--p-text-heading-2xl-font-size`| | `--p-text-heading-3xl-font-weight`| ~`--p-text-heading-xl-font-weight`~<br>`--p-text-heading-2xl-font-weight`| |`--p-text-heading-3xl-font-letter-spacing`| ~`--p-text-heading-xl-font-letter-spacing`~<br>`--p-text-heading-2xl-font-letter-spacing`| | `--p-text-heading-3xl-font-line-height`| ~`--p-text-heading-xl-font-line-height`~<br>`--p-text-heading-2xl-font-line-height`| |~`--p-text-heading-2xl-font-family`~| ~`--p-text-heading-xl-font-family`~| | ~`--p-text-heading-2xl-font-size`~| ~`--p-text-heading-xl-font-size`~| | ~`--p-text-heading-2xl-font-weight`~| ~`--p-text-heading-xl-font-weight`~| | ~`--p-text-heading-2xl-font-letter-spacing`~| ~`--p-text-heading-xl-font-letter-spacing`~| |~`--p-text-heading-2xl-font-line-height`~| ~`--p-text-heading-xl-font-line-height`~| >[!NOTE] >Major version upgrade guidance is updated [on a separate PR on the v13 branch](#11815).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/polaris-internal/issues/1529
WHAT is this pull request doing?
Adds back the Text
heading2xlvariant since it will be kept in the next major version for mobile purposes.