This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Image] Add optional ref prop type
#11884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
force-pushed
the
lo/fix-image-ref
branch
from
dfee1d4 to
efe95ac
Compare
laurkim
changed the title
nullundefined
laurkim
force-pushed
the
lo/fix-image-ref
branch
from
efe95ac to
3362750
Compare
laurkim
force-pushed
the
lo/fix-image-ref
branch
from
035c4c7 to
29ea414
Compare
laurkim
force-pushed
the
lo/fix-image-ref
branch
from
21225af to
8bad150
Compare
laurkim
changed the title
undefinedref prop type
|
/snapit |
|
🫰✨ Thanks @laurkim! Your snapshothas been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240411211213" |
sophschneider
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
TYSM for fixing this!! Not blocking and not sure if this works in your case but you might be able to use forwardRef too
For sure, I updated Image in a previous PR to use forwardRef (just doesn't come up in the diff in this PR haha) 👍 |
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Image without optional ref argument was causing type errors. <img width="1040" alt="11-09-t3waz-qe4ny" src="https://github.com/Shopify/polaris/assets/26749317/82c54744-641f-48d4-bed2-1388c7d3f13f"> ### WHAT is this pull request doing? Explictly adds `ref` as an optional prop type on `ImageProps` ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Image without optional ref argument was causing type errors.
WHAT is this pull request doing?
Explictly adds
refas an optional prop type onImagePropsHow to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes