This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Frame] Accommodate sidebar in scrollbar safe container #11900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @sophschneider! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240417182537" |
sophschneider
force-pushed
the
sidebar-scroll-width
branch
from
9cf18fe to
44f46f3
Compare
|
/snapit |
|
🫰✨ Thanks @sophschneider! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240417184018" |
sophschneider
force-pushed
the
sidebar-scroll-width
branch
from
44f46f3 to
cb5266f
Compare
|
/snapit |
|
🫰✨ Thanks @sophschneider! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240417190320" |
|
going to merge this without approval since its a fast follow up to #11891 and is behind a feature flag |
Merged
sophschneider
pushed a commit
that referenced
this pull request
Apr 17, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@13.1.0 ### Minor Changes - [#11883](#11883) [`a60d8aa4f`](a60d8aa) Thanks [@chloerice](https://github.com/chloerice)! - Added a `disclosureZIndexOverride` prop to `Filters`, `IndexFilters`, and `Tabs` that is passed to `Popover` and `Tooltip` when provided - [#11826](#11826) [`a7fd7ab5d`](a7fd7ab) Thanks [@sophschneider](https://github.com/sophschneider)! - Added `contextualSaveBarVisible` and `contextualSaveBarProps` to `Frame` context ### Patch Changes - [#11842](#11842) [`2a93578af`](2a93578) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed layout shift for option lists within popovers - [#11846](#11846) [`ce6353b97`](ce6353b) Thanks [@sophschneider](https://github.com/sophschneider)! - Restyled Frame content behind dynamicTopBarAndReframe feature flag - [#11872](#11872) [`696bcb725`](696bcb7) Thanks [@mattkubej](https://github.com/mattkubej)! - globally remove link tap highlighting - [#11874](#11874) [`744036706`](7440367) Thanks [@laurkim](https://github.com/laurkim)! - Added support for ref to `Image` to handle image load with `EmptyState` - [#11881](#11881) [`c96ff56a0`](c96ff56) Thanks [@sophschneider](https://github.com/sophschneider)! - Fixed Frame feature override class to get proper max-width for main content. - [#11885](#11885) [`af80d3a82`](af80d3a) Thanks [@craigcolesshopify](https://github.com/craigcolesshopify)! - [indexTable] Fixed over scroll gap on `IndexTable` for sortable last headings with `alignment="end"` - [#11889](#11889) [`374030428`](3740304) Thanks [@chloerice](https://github.com/chloerice)! - Fixed `TextField` zoom on focus due to font-size below 16px - [#11900](#11900) [`215b79271`](215b792) Thanks [@sophschneider](https://github.com/sophschneider)! - Fixed `Frame` scrollbar safe area to accommodate sidebar - [#11842](#11842) [`2a93578af`](2a93578) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed selected icon position in Listbox and OptionList - [#11891](#11891) [`c84d4e875`](c84d4e8) Thanks [@sophschneider](https://github.com/sophschneider)! - Moved `Frame` scrollbar from main to content and set overflow-y from scroll to auto behind a feature flag ## polaris.shopify.com@1.0.1 ### Patch Changes - Updated dependencies \[[`a60d8aa4f`](a60d8aa), [`2a93578af`](2a93578), [`ce6353b97`](ce6353b), [`696bcb725`](696bcb7), [`744036706`](7440367), [`c96ff56a0`](c96ff56), [`af80d3a82`](af80d3a), [`374030428`](3740304), [`215b79271`](215b792), [`a7fd7ab5d`](a7fd7ab), [`2a93578af`](2a93578), [`c84d4e875`](c84d4e8)]: - @shopify/polaris@13.1.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Patching Shopify#11891 to accommodate the sidebar width shift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching #11891 to accommodate the sidebar width shift