Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Conversation

kyledurand
Copy link
Member

WHY are these changes introduced?

Fixes #11784

WHAT is this pull request doing?

Print css wasn't working here, the nesting was odd. To tophat go to render settings in dev tools and emulate print media in prod or storybook.

image

🎩 checklist

@kyledurand kyledurand merged commit 2730292 into main Apr 19, 2024
@kyledurand kyledurand deleted the frame_fix-broken-css branch April 19, 2024 17:40
kyledurand pushed a commit that referenced this pull request Apr 19, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@13.1.2

### Patch Changes

- [#11917](#11917)
[`273029218`](2730292)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed broken css
build error

## polaris.shopify.com@1.0.3

### Patch Changes

- Updated dependencies
\[[`273029218`](2730292)]:
    -   @shopify/polaris@13.1.2

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHY are these changes introduced?

Fixes Shopify#11784

### WHAT is this pull request doing?

Print css wasn't working here, the nesting was odd. To tophat go to
render settings in dev tools and emulate print media in prod or
storybook.


![image](https://github.com/Shopify/polaris/assets/6844391/3e1b0a53-5dc5-4d94-be83-151003856ae3)

### 🎩 checklist

- [ ] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid CSS syntax in latest builds
2 participants