[Frame] Only add rounded styles when topBar exists
#11925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @sophschneider! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240422163353" |
sophschneider
force-pushed
the
frame-top-bar-webviews
branch
from
cbb64a2 to
f3acc67
Compare
sophschneider
commented
Apr 22, 2024
|
|
||
| this.setRootAttributes(); | ||
| /* Temporary for dynamicTopBarAndReframe feature. Remove when feature flag is removed. */ | ||
| this.setBodyStyles(); |
There was a problem hiding this comment.
Moving changes from https://github.com/Shopify/polaris/pull/11846/files#diff-a7232fda7d9031ace7080a5155b4ddb352a1c6fdd5b75d0361a22b747f80be54 to Frame so I can conditionally apply based on the topBar prop.
sophschneider
changed the title
topBar exists
kyledurand
approved these changes
Apr 22, 2024
|
@kyledurand yes! we'll need to round the corners of it Figma link. Just made an issue for it, thanks for noticing :D |
Merged
sophschneider
pushed a commit
that referenced
this pull request
Apr 24, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@13.2.0 ### Minor Changes - [#11535](#11535) [`bcd16df24`](bcd16df) Thanks [@ShabanaRumane](https://github.com/ShabanaRumane)! - Added support for setting `maxHeight` and `minHeight` on `Popover.Pane` and `Combobox` - [#11907](#11907) [`45308c97a`](45308c9) Thanks [@zakwarsame](https://github.com/zakwarsame)! - Added an optional `fiterLabel` prop to `ActionList` to allow for a custom placeholder ### Patch Changes - [#11897](#11897) [`a83084b3b`](a83084b) Thanks [@jesstelford](https://github.com/jesstelford)! - Fixed edges of disabled `IndexTable.Row` `Checkbox` triggering selection - [#11924](#11924) [`5ec70e688`](5ec70e6) Thanks [@jesstelford](https://github.com/jesstelford)! - Upgrade to jest 29 - [#11929](#11929) [`9ee700be6`](9ee700b) Thanks [@sophschneider](https://github.com/sophschneider)! - Rounded `Navigation` at `mdDown` behind a feature flag - [#11923](#11923) [`ce13c4366`](ce13c43) Thanks [@jesstelford](https://github.com/jesstelford)! - Update dev dependency: `postcss-import@^15.1.0` -> `postcss-import@^16.1.0` - [#11925](#11925) [`364ada59e`](364ada5) Thanks [@sophschneider](https://github.com/sophschneider)! - Updated Frame to only apply rounded Frame when passed a `topBar` - [#11734](#11734) [`1fef06256`](1fef062) Thanks [@jesstelford](https://github.com/jesstelford)! - Upgrade to Storybook v8 - [#11898](#11898) [`1539f0e7c`](1539f0e) Thanks [@jesstelford](https://github.com/jesstelford)! - Removed extra padding around `IndexTable.Row` `Checkbox` - [#11927](#11927) [`5a32a3ff6`](5a32a3f) Thanks [@sophschneider](https://github.com/sophschneider)! - Added `prefers-reduced-motion` media queries to `Frame` width transitions - [#11930](#11930) [`b111629d7`](b111629) Thanks [@jesstelford](https://github.com/jesstelford)! - Migrate Storybook stories to CSF v3 - [#11805](#11805) [`0a9b72721`](0a9b727) Thanks [@LA1CH3](https://github.com/LA1CH3)! - Fixed `IndexTable` `loading` prop to correctly show/hide loading UI when prop value changes - Updated dependencies \[[`5ec70e688`](5ec70e6)]: - @shopify/polaris-icons@9.0.1 - @shopify/polaris-tokens@9.0.1 ## @shopify/polaris-icons@9.0.1 ### Patch Changes - [#11924](#11924) [`5ec70e688`](5ec70e6) Thanks [@jesstelford](https://github.com/jesstelford)! - Upgrade to jest 29 ## @shopify/polaris-migrator@1.0.1 ### Patch Changes - [#11924](#11924) [`5ec70e688`](5ec70e6) Thanks [@jesstelford](https://github.com/jesstelford)! - Upgrade to jest 29 - [#11930](#11930) [`b111629d7`](b111629) Thanks [@jesstelford](https://github.com/jesstelford)! - Migrate Storybook stories to CSF v3 - Updated dependencies \[[`5ec70e688`](5ec70e6)]: - @shopify/polaris-tokens@9.0.1 - @shopify/stylelint-polaris@16.0.1 ## @shopify/polaris-tokens@9.0.1 ### Patch Changes - [#11924](#11924) [`5ec70e688`](5ec70e6) Thanks [@jesstelford](https://github.com/jesstelford)! - Upgrade to jest 29 ## @shopify/stylelint-polaris@16.0.1 ### Patch Changes - Updated dependencies \[[`5ec70e688`](5ec70e6)]: - @shopify/polaris-tokens@9.0.1 ## polaris-for-vscode@1.0.1 ### Patch Changes - Updated dependencies \[[`5ec70e688`](5ec70e6)]: - @shopify/polaris-tokens@9.0.1 ## polaris.shopify.com@1.0.4 ### Patch Changes - [#11924](#11924) [`5ec70e688`](5ec70e6) Thanks [@jesstelford](https://github.com/jesstelford)! - Upgrade to jest 29 - Updated dependencies \[[`a83084b3b`](a83084b), [`5ec70e688`](5ec70e6), [`9ee700be6`](9ee700b), [`bcd16df24`](bcd16df), [`ce13c4366`](ce13c43), [`364ada59e`](364ada5), [`1fef06256`](1fef062), [`45308c97a`](45308c9), [`1539f0e7c`](1539f0e), [`5a32a3ff6`](5a32a3f), [`b111629d7`](b111629), [`0a9b72721`](0a9b727)]: - @shopify/polaris@13.2.0 - @shopify/polaris-icons@9.0.1 - @shopify/polaris-tokens@9.0.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-internal/issues/1598
WHAT is this pull request doing?
Only applies rounded frame styles when the
Framecomponent has atopBarpropHow to 🎩
For
WithoutATopBar, make sure story is the same with feature flag on and offhttps://admin.web.web-81d9.sophie-schneider.us.spin.dev/store/shop1
🎩 checklist