Skip to content

Conversation

iangermann
Copy link

WHY are these changes introduced?

The pnpm-lock.yaml file is currently broken in main:

ERR_PNPM_BROKEN_LOCKFILE  The lockfile at "/home/runner/work/polaris/polaris/pnpm-lock.yaml" is broken: duplicated mapping key (8175:3)

 [8](https://github.com/Shopify/polaris/actions/runs/11707524346/job/32607095304#step:7:9)172 |       '@babel/core': 7.26.0

WHAT is this pull request doing?

This PR is upgrading the remaining Storybook packages from 8.0.0 to 8.4.1 which fixes the build and unblocks CI.
It should also close the remaining Storybook dependabot PRs.

I've confirmed that pnpm install && pnpm build runs locally now, and I'm able to run Storybook locally again.

Screenshot

Screenshot 2024-11-07 at 6 02 35 PM

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@iangermann iangermann force-pushed the upgrade-storybook-packages branch from 355f64b to b6d2332 Compare November 7, 2024 23:06
@iangermann iangermann marked this pull request as ready for review November 7, 2024 23:15
@nandinicbit1981 nandinicbit1981 requested a review from a team November 8, 2024 15:10
@@ -0,0 +1,2 @@
---
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add the skip changeset tag and delete this changeset!

@iangermann iangermann force-pushed the upgrade-storybook-packages branch from b6d2332 to d6511e9 Compare November 8, 2024 16:16
@iangermann iangermann added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Nov 8, 2024
@iangermann iangermann merged commit 356c1bc into main Nov 8, 2024
12 of 13 checks passed
@iangermann iangermann deleted the upgrade-storybook-packages branch November 8, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants