This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Fixing TextField clear button in Safari #13413
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @jeffrey-ben! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20250320204209" |
|
👋 Tophat works great on the Polaris side - but when I update the package.json with the snapshot version in Collective, the bug persists 🤔 There's also this weird behaviour where all buttons have a red outline (?) Wondering if I am missing a step somewhere 
|
|
To be sure, I fired up an empty next.js project, can confirm I can clear the text field in safari, and didn't have any of the outline issues you were describing (probably something in the CSS variables of the specific environment?) |
Aubron
approved these changes
Mar 25, 2025
Merged
jeffrey-ben
pushed a commit
that referenced
this pull request
Mar 26, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@13.9.5 ### Patch Changes - [#13413](#13413) [`730349b`](730349b) Thanks [@jeffrey-ben](https://github.com/jeffrey-ben)! - Fixed TextField clear bug in Safari ## polaris.shopify.com@1.1.4 ### Patch Changes - Updated dependencies \[[`730349b`](730349b)]: - @shopify/polaris@13.9.5 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The clear button in TextField components were not working in Safari. This bug was raised previously (issue linked below) and a fix was merged in polaris-internal.
The fix merged in polaris-internal can be seen here https://github.com/Shopify/polaris-internal/pull/895
This PR adds the same fix into the external Polaris version.
Fixes https://github.com/Shopify/merchant-to-merchant/issues/20327
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes