This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Migrator] Add migrate-motion migration for transition easing function #7431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesstelford
force-pushed
the
migrate-motion-easing
branch
from
e08d5cc to
5117c24
Compare
sam-b-rose
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
This is looking 🔥 💯 love the use of the property keys in the plugin Declaration object. Is this ready to run on web or are there still edge-cases that need to be handled?
Also, can you add a small bit of documentation for this migration in the migrator package README.md?
|
/snapit |
|
🫰✨ Thanks @jesstelford! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20221020231634yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20221020231634yarn add @shopify/polaris@0.0.0-snapshot-release-20221020231634 |
jesstelford
force-pushed
the
migrate-motion-easing
branch
from
5117c24 to
e559f7d
Compare
|
/snapit |
|
🫰✨ Thanks @jesstelford! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20221021024254yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20221021024254yarn add @shopify/polaris@0.0.0-snapshot-release-20221021024254 |
|
These additions have been combined into #7403 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Includes changes in #7403, so that PR should be merged first. In the mean-time, you can view the changes for this PR only.
WHY are these changes introduced?
ref #7213
This PR covers the
transitionandtransition-timing-functionproperties, their various complex uses and a couple of edge cases as seen in the wild.WHAT is this pull request doing?
Example migrations (taken from the test files):
transition-timing-function: linear↳
transition-timing-function: var(--p-linear)transition-timing-function: legacy-polaris-v8.easing('in')↳
transition-timing-function: var(--p-ease-in);transition: opacity 300ms legacy-polaris-v8.easing('base');↳
transition: opacity var(--p-duration-300) var(--p-ease);Will output various error messages for things it can't migrate:
transition-timing-function: legacy-polaris-v8.easing(anticipate);↳
transition-timing-function: cubic-bezier(0, 0, 1, 1);↳
Open Question: Do we consider
cubic-bezier()/linear()/ other built-in CSS easing functions as failures? I assume so (and have coded it to insert a comment when they're detected), but want to be sure before this gets merged.